The code is already better (it's factored) in 2.5 and master, and does not trigger GCC warnings. So this is 2.4.3 only.
From a151f354cfd8627b3fb1930bf95d42d7af973af6 Mon Sep 17 00:00:00 2001 From: Akim Demaille <[email protected]> Date: Wed, 21 Jul 2010 18:10:50 +0200 Subject: [PATCH] Pacify gcc warnings. * src/getargs.c (skeleton_arg): Pass "%s" to printf-like functions with variable format and no argument. --- ChangeLog | 6 ++++++ src/getargs.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 2da62cc..64aaf00 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2010-07-21 Akim Demaille <[email protected]> + + Pacify gcc warnings. + * src/getargs.c (skeleton_arg): Pass "%s" to printf-like functions + with variable format and no argument. + 2010-06-17 Paul Eggert <[email protected]> Update from GFDL GFDL 1.2 to 1.3. diff --git a/src/getargs.c b/src/getargs.c index 27bc897..7cbb42e 100644 --- a/src/getargs.c +++ b/src/getargs.c @@ -370,9 +370,9 @@ skeleton_arg (char const *arg, int prio, location const *loc) char const *msg = _("multiple skeleton declarations are invalid"); if (loc) - complain_at (*loc, msg); + complain_at (*loc, "%s", msg); else - complain (msg); + complain ("%s", msg); } } -- 1.7.1.1
