> On 20 Nov 2018, at 21:32, Paul Eggert <egg...@cs.ucla.edu> wrote: > > On 11/20/18 12:01 PM, Akim Demaille wrote: >> - if (false) >> + if ((false)) > > This goes too far. If clang is warning about this sort of thing, then we > should disable that clang warning. Again, compilers should be our servants, > not our masters.
That seems a good idea. One I disabled is Clang enforcing the limited logical expression precedence levels of Pascal, forcing the use of unneeded extra parentheses. https://clang.llvm.org/docs/DiagnosticsReference.html#wlogical-op-parentheses
