Hi Anonymous Maarten, Is this really the name I should use to refer to you, in the commit messages and in THANKS?
Thanks for the report and fixes! > Le 30 juil. 2020 à 20:53, [email protected] a écrit : > > From: Anonymous Maarten <[email protected]> > > Conan [1], a c/c++ package manager, provides a recipes and packages for > libraries and programs built using common architectures, compilers and > operating > systems. It mostly caters developers. > The public recipe for bison is available at conan-center-index [2]. That's great. I was unaware there was a recipe for Bison. > Building bison on Visual Studio (MSVC) causes some compile errors, > which I try to address in these patches. > They mostly rename symbols to avoid symbol redefinition errors. Grr. I'm very unhappy with these constraints. Where are they coming from? Why don't we get rid of these spurious symbols instead? For instance in the case of max, NOMINMAX should get rid of it, doesn't it? What's the path of inclusion of headers that brings these guys? Where is CHAR coming from? I guess it's a macro, so we should be able to undef it, right? > In the first patch, I hid the inclusion of 2 files behind a macro. > I haven't checked whether these missing files can be provided through > gnulib. It appears there is. I'm looking into this right now. Cheers!
