On Fri, Jul 16, 2010 at 11:16 AM, C Michael Sundius <[email protected]>wrote:
> I created this fetcher class for the source code control system that we are > using. I'd be surprised if anyone else uses this, But if someone out there > IS using it, I'd love to know so we can work together. > > also, being a Python dummy, I'd love some comments on what I've done > (right, wrong, good, bad, ugly). > > note that before running bitbake I call the "ccm start" command and then > "export CCM_ADDR" since that is a one time setup that needs to be done. > > for now a url looks like this: > > ccm://<project-name>,<project-version/baseline> > I'm curious about doparse. Is urlsplit not working the way it should? If there's a bug with it, I'd rather just fix it :) I'd suggest os.path.isabs() rather than poking at base[0]. Might be able to simplify your localpath function a little. You set up your tar filename and return the joined path to dldir the same way in both places, and you never actually use the 'base' or 'which' variables, so much of that logic is unnecessary given the current implementation. Other than that, looks fine to me. Sorry for the delay. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
_______________________________________________ Bitbake-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bitbake-dev
