Hi,
I've just noticed merging few fetcher patches from poky in
http://git.openembedded.org/cgit.cgi/bitbake/commit/?id=3aaddb8c434d0ea839c0b52de5a56be1be4641dd
one of them is:
bitbake/git.py: Make sure different branches can have different revisions
without triggering build count increases
But I don't see anything for conversion from "old" format without branch
to "new" with branch in the end. So if I understand it right all git
build numbers will start from 0 and will break upgradeable path unless
someone bump PE in all those recipes in OE.
I agree that having branch in that key is good thing, but please advise
how to migrate peristent database to get upgradeable paths (not even
talking about switching bitbake version 1.10 and master back and forth.
BTW: if there is ie _branch prefix then it would be easier to prepare
sql script updating values from keys without "branch.[^_]*_" to key with
branch specified for conversion, but as every builder has to convert, it
would be better to do something like:
add "def generate_revision_old_key(self, url, ud, d):" with old behavior
key = self.generate_revision_key(url, ud, d)
last_rev = pd.getValue("BB_URI_LOCALCOUNT", key + "_rev")
uselocalcount = bb.data.getVar("BB_LOCALCOUNT_OVERRIDE", d, True) or False
if last_rev is None
oldkey = self.generate_revision_old_key(url, ud, d)
last_rev = pd.getValue("BB_URI_LOCALCOUNT", oldkey + "_rev")
...
if count is None:
count = pd.getValue("BB_URI_LOCALCOUNT", key + "_count")
if count is None:
count = pd.getValue("BB_URI_LOCALCOUNT", oldkey + "_count")
Regards,
--
Martin 'JaMa' Jansa jabber: [email protected]
_______________________________________________
Bitbake-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bitbake-dev
