> Upon looking at the 0.8.5 & earlier code for CDB:Rewrite(), in the > files db.h and db.cpp, you will notice that in db.h it is declared > bool static, but in db.cpp it isn't. Is this a problem? Or a feature? > Or nothing at all?
It is perfect C++ code. > Furthermore, it is called only in wallet.cpp > -->CWallet::EncryptWallet() but its return value is ignored? Again, > intentional or a bug or a feature or a ...? possibly a minor bug. Minor because over 99% of the time it is called, the Rewrite() function will succeed. Maybe CWallet::EncryptWallet() should return false to its callers when CDB::Rewrite fails. ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ Bitcoin-development mailing list Bitcoin-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bitcoin-development
