Hmm, I think I've seen that on a small scale, where sometimes 7 rather
than 6 peers were connected. One fundamental problem is if you try to
connect to a number of peers to fill up your quota, you don't know how
many peers will actually get fully connected.

Anyway, I think the last one to work on the connection management was
Devrandom. Maybe he wants to take a look?

I noticed your branch isn't rebased on current master (or at least a
recent 0.14 release). Any chance you can do that?


On 06/16/2016 02:40 PM, Manfred Karrer wrote:
> BitcoinJ gets too many connections after a reconnect as it adds up a lot
> of potential candidates (inactives) and then try to connect to all of
> those when getting the connection again. A check for maxConnections is
> missing to not exceed connections. The nr. of connections I observed was
>> 100.
> 
> I added in my branch a fix for that, though as I am not very familiar
> with the BitcoinJ code base I don't want to do a PR here.
> Someone who knows BitcoinJ better might find a better place to add that
> check.
> 
> Here is my fix:
> https://github.com/bitsquare/bitcoinj/commit/e112b139d1f10c2245f78ec5dab93c19f5f8aca2
> 
> -- 
> You received this message because you are subscribed to the Google
> Groups "bitcoinj" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to [email protected]
> <mailto:[email protected]>.
> For more options, visit https://groups.google.com/d/optout.


-- 
You received this message because you are subscribed to the Google Groups 
"bitcoinj" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to