Thanks for your response! > On 5 Jan 2018, at 16:14, Andreas Schildbach <[email protected] > <mailto:[email protected]>> wrote: > > Yes, or maybe the fee is too low?
No, I don’t think so. The fees are based on a fee estimation and currently tend to overpay. > As far as I can remember, nodes are > still not required to report back and errors (and bitcoinj currently > does not do anything with REJECT messages other than logging them). I have not seen reject logs in the reported cases. > > Also, if you don't hear back from the network transactions are not > committed, which may lead to them being forgotten entirely. If that's > not what you want, you might want to manually commit them first and then > broadcast them. That's what Bitcoin Wallet is doing too because a > disappearing transaction (e.g. because a broken Internet connection) > will confuse users. Thanks for the info. After analysing more logs I saw that the confidence listener is not called when the dependency download is completed. Jan-06 10:20:09.933 [JavaFX Application Thread] INFO o.b.c.TransactionBroadcast: Waiting for 7 peers required for broadcast, we have 9 ... Jan-06 10:20:09.940 [JavaFX Application Thread] INFO o.b.c.TransactionBroadcast: broadcastTransaction: We have 9 peers, adding 1a45a1fae195229c54bb5015763b9d5594a7677523da41d78749bc99919ac487 to the memory pool Jan-06 10:20:09.940 [JavaFX Application Thread] INFO o.b.c.TransactionBroadcast: Sending to 5 peers, will wait for 2, sending to: [vlf5i3grro3wux24.onion]:8333,[sjyzmwwu6diiit3r.onion]:8333,[mxdtrjhe2yfsx3pg.onion]:8333,[r3dsojfhwcm7x7p6.onion]:8333,[lgkvbvro67jomosw.onion]:8333 Jan-06 10:20:18.688 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.core.Peer: [i3a5xtzfm4xwtybd.onion]:8333: Downloading dependencies of 1a45a1fae195229c54bb5015763b9d5594a7677523da41d78749bc99919ac487 Jan-06 10:20:20.180 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.core.Peer: [i3a5xtzfm4xwtybd.onion]:8333: Bottomed out dep tree at a9265dab41da2114bea986ba7caf6f1138f705e5a1ee779cd60dfaab1c33c39d Jan-06 10:20:20.195 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.core.Peer: [i3a5xtzfm4xwtybd.onion]:8333: Dependency download complete! Jan-06 10:20:20.198 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.w.Wallet: Received a pending transaction 1a45a1fae195229c54bb5015763b9d5594a7677523da41d78749bc99919ac487 that spends 0.03779269 BTC from our own wallet, and sends us 0.03637069 BTC Jan-06 10:20:20.213 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.w.Wallet: commitTx of 1a45a1fae195229c54bb5015763b9d5594a7677523da41d78749bc99919ac487 Jan-06 10:20:20.217 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.w.Wallet: marked a9265dab41da2114bea986ba7caf6f1138f705e5a1ee779cd60dfaab1c33c39d:8 as spent by 1a45a1fae195229c54bb5015763b9d5594a7677523da41d78749bc99919ac487 Jan-06 10:20:20.232 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.w.Wallet: a9265dab41da2114bea986ba7caf6f1138f705e5a1ee779cd60dfaab1c33c39d prevtx <-unspent ->spent Jan-06 10:20:20.233 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.w.Wallet: ->pending: 1a45a1fae195229c54bb5015763b9d5594a7677523da41d78749bc99919ac487 Jan-06 10:20:20.233 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.w.Wallet: Estimated balance is now: 0.03637069 BTC Jan-06 10:20:20.241 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.w.WalletFiles: Saving wallet; last seen block is height 502869, date 2018-01-06T15:18:21Z, hash 0000000000000000007ebb7c581f16df5a5f425cf45d1d038c81cd278ccd33b7 Jan-06 10:20:20.292 [BlockingClient network thread for i3a5xtzfm4xwtybd.onion:8333] INFO o.b.w.WalletFiles: Save completed in 36.60 ms Jan-06 10:23:10.689 [BlockingClient network thread for 3r44ddzjitznyahw.onion:8333] INFO o.b.w.Wallet: Received tx for -0.001422 BTC: 1a45a1fae195229c54bb5015763b9d5594a7677523da41d78749bc99919ac487 [0] in block 00000000000000000061abcd4f51d81ddba5498cff67fed44b287de0990b7266 Jan-06 10:23:10.704 [BlockingClient network thread for 3r44ddzjitznyahw.onion:8333] INFO o.b.w.Wallet: <-pending Jan-06 10:23:10.719 [BlockingClient network thread for 3r44ddzjitznyahw.onion:8333] INFO o.b.w.Wallet: tx 1a45a1fae195229c54bb5015763b9d5594a7677523da41d78749bc99919ac487 ->unspent Jan-06 10:23:10.720 [BlockingClient network thread for 3r44ddzjitznyahw.onion:8333] INFO o.b.w.Wallet: Balance is now: 0.03637069 BTC Jan-06 10:23:10.738 [BlockingClient network thread for 3r44ddzjitznyahw.onion:8333] INFO o.b.w.WalletFiles: Saving wallet; last seen block is height 502870, date 2018-01-06T15:22:58Z, hash 00000000000000000061abcd4f51d81ddba5498cff67fed44b287de0990b7266 Jan-06 10:23:10.776 [BlockingClient network thread for 3r44ddzjitznyahw.onion:8333] INFO o.b.w.WalletFiles: Save completed in 37.43 ms After that nothing happens anymore. the confidence listener is not called. As far I saw in the code the confidence listener is only called from inside the Peer.processInv method. As far I understand the Inv msg from the full node triggers the getData msg and we get the tx delivered in the next msg. In the above case the dependent tx is in the chains so it stops after the first download. As the Inv msg is not logged I am not sure if we ever get the inv msg but only the tx. Can it be that the full node sends the tx without inv or that BitcoinJ sends the getData msg without inv? Another explanation might be that the full node gets the broadcasted tx but we don’t get back the inv msg for some reason (we use tor and there are issues in the tor network the last weeks). But we should get inv msg from several peers if we are connected to 9 peers. Does the full node which receives the tx send back an inv as well? Here is the log of a normal successful tx broadcast without dependency download: Jan-03 11:36:43.521 [JavaFX Application Thread] INFO o.b.c.TransactionBroadcast: Sending to 5 peers, will wait for 2, sending to: [c6ac4jdfyeiakex2.onion]:8333,[vlf5i3grro3wux24.onion]:8333,[r3dsojfhwcm7x7p6.onion]:8333,[poyvpdt762gllauu.onion]:8333,[mxdtrjhe2yfsx3pg.onion]:8333 Jan-03 11:36:47.014 [JavaFX Application Thread] INFO o.b.c.TransactionBroadcast: broadcastTransaction: SEEN_PEERS: TX acf95ae015012980d8700cfb6b6eb76257eb9e2ddba085c8a3ddeb3da11097d0 seen by 1 peers Jan-03 11:36:48.314 [JavaFX Application Thread] INFO o.b.c.TransactionBroadcast: broadcastTransaction: SEEN_PEERS: TX acf95ae015012980d8700cfb6b6eb76257eb9e2ddba085c8a3ddeb3da11097d0 seen by 2 peers Jan-03 11:36:48.318 [JavaFX Application Thread] INFO o.b.c.TransactionBroadcast: broadcastTransaction: acf95ae015012980d8700cfb6b6eb76257eb9e2ddba085c8a3ddeb3da11097d0 complete I assume that the dependent tx was in the blockchain or we have it already downloaded earlier, so there was nothing to download. I am wondering if the weak listeners might cause an issues. The errors are occurring just from time to time. Any ideas? > > > On 01/04/2018 09:45 PM, Manfred Karrer wrote: >> We get in Bisq since roughly 1-2 month repeated issues with tx broadcasts. >> >> The onConfidenceChanged is never called at the ConfidenceChange listener >> in TransactionBroadcast which leads then to timeouts in the trade >> protocol. The transaction gets successfully broadcasted though BitcoinJ >> does not hear back from the full nodes or do not notify the listener. >> >> I have seen in the master branch that support for version 2 transactions >> has been added which seems to be at least in one case the reason for the >> problems as I got warnings in the logs reagarding non-standard and >> unrecognized version nr., but I have seen other cases where that does >> not seem to be the cause. >> >> Any idea what can cause those problems? >> I assume it is related to unconfirmed txs used for the inputs and >> BitcoinJ seems to not call the onConfidenceChanged. >> >> >> Typical logs for a tx which gets broadcasted: >> >> Dec-28 15:49:50.451 [JavaFX Application Thread] INFO >> o.b.c.TransactionBroadcast: Waiting for 7 peers required for broadcast, >> we have 9 ... >> Dec-28 15:49:50.451 [JavaFX Application Thread] INFO >> o.b.c.TransactionBroadcast: broadcastTransaction: We have 9 peers, >> adding 227c6310c01094ba57df6dd2f303a453389fa5b5c31bd752dc2946ca747456a5 >> to the memory pool >> Dec-28 15:49:50.451 [JavaFX Application Thread] INFO >> o.b.c.TransactionBroadcast: Sending to 5 peers, will wait for 2, >> sending to: >> [mxdtrjhe2yfsx3pg.onion]:8333,[3r44ddzjitznyahw.onion]:8333,[c6ac4jdfyeiakex2.onion]:8333,[sjyzmwwu6diiit3r.onion]:8333,[vlf5i3grro3wux24.onion]:8333 >> Dec-28 15:49:53.585 [JavaFX Application Thread] INFO >> o.b.c.TransactionBroadcast: broadcastTransaction: SEEN_PEERS: TX >> 227c6310c01094ba57df6dd2f303a453389fa5b5c31bd752dc2946ca747456a5 seen by >> 1 peers >> Dec-28 15:49:53.631 [JavaFX Application Thread] INFO >> o.b.c.TransactionBroadcast: broadcastTransaction: SEEN_PEERS: TX >> 227c6310c01094ba57df6dd2f303a453389fa5b5c31bd752dc2946ca747456a5 seen by >> 2 peers >> Dec-28 15:49:53.631 [JavaFX Application Thread] INFO >> o.b.c.TransactionBroadcast: broadcastTransaction: >> 227c6310c01094ba57df6dd2f303a453389fa5b5c31bd752dc2946ca747456a5 complete >> Dec-28 15:49:53.632 [JavaFX Application Thread] INFO o.b.w.Wallet: >> Received a pending transaction >> 227c6310c01094ba57df6dd2f303a453389fa5b5c31bd752dc2946ca747456a5 that >> spends 0.005153 BTC from our own wallet, and sends us 0.003731 BTC >> Dec-28 15:49:53.632 [JavaFX Application Thread] INFO o.b.w.Wallet: >> commitTx of 227c6310c01094ba57df6dd2f303a453389fa5b5c31bd752dc2946ca747456a5 >> Dec-28 15:49:53.633 [JavaFX Application Thread] INFO o.b.w.Wallet: >> marked >> 24ca182732bb3ca386dd2aa5ea4f9bd3223319862b5d35b7c8d10a58ff1ff5d5:2 as >> spent by 227c6310c01094ba57df6dd2f303a453389fa5b5c31bd752dc2946ca747456a5 >> Dec-28 15:49:53.633 [JavaFX Application Thread] INFO o.b.w.Wallet: >> ->pending: 227c6310c01094ba57df6dd2f303a453389fa5b5c31bd752dc2946ca747456a5 >> Dec-28 15:49:53.634 [JavaFX Application Thread] INFO o.b.w.Wallet: >> Estimated balance is now: 0.005731 BTC >> Dec-28 15:49:53.635 [JavaFX Application Thread] INFO o.b.w.WalletFiles: >> Saving wallet; last seen block is height 501436, date >> 2017-12-28T15:47:16Z, hash >> 0000000000000000001ef574fe2b15a338b53da3fa0ce60e3e5695b384192685 >> Dec-28 15:49:53.731 [JavaFX Application Thread] INFO o.b.w.WalletFiles: >> Save completed in 95.79 ms >> Dec-28 15:49:53.789 [JavaFX Application Thread] INFO >> i.b.c.b.w.BtcWalletService: swap addressEntry with address >> 15JSW1Ki2hqbi2ugg42LtewXGc7pJnoCsa and offerId >> V6W7W86-0166f8d9-7c2b-4490-b005-cef0a18eed7d-062 from context >> OFFER_FUNDING to available >> Dec-28 15:49:53.790 [JavaFX Application Thread] INFO >> i.b.c.t.TaskRunner: Run task: AddOfferOfferBook >> >> >> Typical logs for a tx which fails to get broadcasted >> (broadcastTransaction: SEEN_PEERS never called): >> >> Jan-02 04:10:59.891 [JavaFX Application Thread] INFO >> o.b.c.TransactionBroadcast: Waiting for 7 peers required for broadcast, >> we have 9 ... >> Jan-02 04:10:59.892 [JavaFX Application Thread] INFO >> o.b.c.TransactionBroadcast: broadcastTransaction: We have 9 peers, >> adding 42c98fc9ce2622f2aeae65828639c6389cf573c4e97600c2c28652d687b9a00a >> to the memory pool >> Jan-02 04:10:59.892 [JavaFX Application Thread] INFO >> o.b.c.TransactionBroadcast: Sending to 5 peers, will wait for 2, >> sending to: >> [4jyh6llqj264oggs.onion]:8333,[c6ac4jdfyeiakex2.onion]:8333,[sjyzmwwu6diiit3r.onion]:8333,[fz6nsij6jiyuwlsc.onion]:8333,[i3a5xtzfm4xwtybd.onion]:8333 >> Jan-02 04:11:03.922 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.core.Peer: >> [mxdtrjhe2yfsx3pg.onion]:8333: Downloading dependencies of >> 42c98fc9ce2622f2aeae65828639c6389cf573c4e97600c2c28652d687b9a00a >> Jan-02 04:11:04.515 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.core.Peer: >> [mxdtrjhe2yfsx3pg.onion]:8333: Downloaded dependency of >> 42c98fc9ce2622f2aeae65828639c6389cf573c4e97600c2c28652d687b9a00a: >> 09b9765de45cc7be1d4bb9c78b161900d2d7a6bf997421996ddaa3c439d1443b >> Jan-02 04:11:04.515 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.core.Peer: >> [mxdtrjhe2yfsx3pg.onion]:8333: Requesting 3 transactions for depth 2 dep >> resolution >> Jan-02 04:11:05.338 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.core.Peer: >> [mxdtrjhe2yfsx3pg.onion]:8333: Bottomed out dep tree at >> 5439eaa3b1385cb369962fa194c412a565c66d7068aa67fc08d09e09524dd5ee >> Jan-02 04:11:05.353 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.core.Peer: >> [mxdtrjhe2yfsx3pg.onion]:8333: Bottomed out dep tree at >> d25c2784c00784ba6183953b368abbb1ed64d7431942c472ebc82e5d39302f4d >> Jan-02 04:11:05.353 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.core.Peer: >> [mxdtrjhe2yfsx3pg.onion]:8333: Bottomed out dep tree at >> 63dd32c29d0f64f0df1ea101f2e7ab219ffda1b05984a7d460be52a96ad6ee3f >> Jan-02 04:11:05.353 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.core.Peer: >> [mxdtrjhe2yfsx3pg.onion]:8333: Dependency download complete! >> Jan-02 04:11:05.361 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.w.Wallet: Received a pending >> transaction >> 42c98fc9ce2622f2aeae65828639c6389cf573c4e97600c2c28652d687b9a00a that >> spends 0.00776825 BTC from our own wallet, and sends us 0.00592025 BTC >> Jan-02 04:11:05.361 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.w.Wallet: commitTx of >> 42c98fc9ce2622f2aeae65828639c6389cf573c4e97600c2c28652d687b9a00a >> Jan-02 04:11:05.361 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.w.Wallet: marked >> 09b9765de45cc7be1d4bb9c78b161900d2d7a6bf997421996ddaa3c439d1443b:2 as >> spent by 42c98fc9ce2622f2aeae65828639c6389cf573c4e97600c2c28652d687b9a00a >> Jan-02 04:11:05.376 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.w.Wallet: ->pending: >> 42c98fc9ce2622f2aeae65828639c6389cf573c4e97600c2c28652d687b9a00a >> Jan-02 04:11:05.376 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.w.Wallet: Estimated balance is >> now: 0.00742025 BTC >> Jan-02 04:11:05.376 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.w.WalletFiles: Saving wallet; last >> seen block is height 502154, date 2018-01-02T04:08:22Z, hash >> 00000000000000000010a68a4a70ee51587a6407c632210600f25566ec1259d9 >> Jan-02 04:11:05.428 [BlockingClient network thread for >> mxdtrjhe2yfsx3pg.onion:8333] INFO o.b.w.WalletFiles: Save completed in >> 51.93 ms >> Jan-02 04:11:32.019 [BlockingClient network thread for >> poyvpdt762gllauu.onion:8333] INFO o.b.w.Wallet: Received tx for >> -0.001848 BTC: >> 42c98fc9ce2622f2aeae65828639c6389cf573c4e97600c2c28652d687b9a00a [0] in >> block 0000000000000000007183318f5aa70f4b53c4e2223183c72f8b42c4fcae273f >> Jan-02 04:11:32.019 [BlockingClient network thread for >> poyvpdt762gllauu.onion:8333] INFO o.b.w.Wallet: <-pending >> Jan-02 04:11:32.019 [BlockingClient network thread for >> poyvpdt762gllauu.onion:8333] INFO o.b.w.Wallet: tx >> 42c98fc9ce2622f2aeae65828639c6389cf573c4e97600c2c28652d687b9a00a ->unspent >> Jan-02 04:11:32.020 [BlockingClient network thread for >> poyvpdt762gllauu.onion:8333] INFO o.b.w.Wallet: Balance is now: >> 0.00742025 BTC >> Jan-02 04:11:32.020 [BlockingClient network thread for >> poyvpdt762gllauu.onion:8333] INFO o.b.w.WalletFiles: Saving wallet; last >> seen block is height 502155, date 2018-01-02T04:11:33Z, hash >> 0000000000000000007183318f5aa70f4b53c4e2223183c72f8b42c4fcae273f >> Jan-02 04:11:32.335 [BlockingClient network thread for >> poyvpdt762gllauu.onion:8333] INFO o.b.w.WalletFiles: Save completed in >> 314.9 ms >> Jan-02 04:11:37.020 [Wallet autosave thread] INFO o.b.w.WalletFiles: >> Background saving wallet; last seen block is height 502155, date >> 2018-01-02T04:11:33Z, hash >> 0000000000000000007183318f5aa70f4b53c4e2223183c72f8b42c4fcae273f >> Jan-02 04:11:37.229 [Wallet autosave thread] INFO o.b.w.WalletFiles: >> Save completed in 208.8 ms >> Jan-02 04:11:37.346 [Wallet autosave thread] INFO o.b.w.WalletFiles: >> Background saving wallet; last seen block is height 502155, date >> 2018-01-02T04:11:33Z, hash >> 0000000000000000007183318f5aa70f4b53c4e2223183c72f8b42c4fcae273f >> Jan-02 04:11:37.597 [Wallet autosave thread] INFO o.b.w.WalletFiles: >> Save completed in 251.0 ms >> >> -- >> You received this message because you are subscribed to the Google >> Groups "bitcoinj" group. >> To unsubscribe from this group and stop receiving emails from it, send >> an email to [email protected] >> <mailto:[email protected]> >> <mailto:[email protected] >> <mailto:[email protected]>>. >> For more options, visit https://groups.google.com/d/optout >> <https://groups.google.com/d/optout>. > > > -- > You received this message because you are subscribed to the Google Groups > "bitcoinj" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "bitcoinj" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
