Agreed. I have other priorities, so I will put this on hold for now.
On Thu, Mar 14, 2019 at 9:30 AM Andreas Schildbach <andr...@schildbach.de> wrote: > > Dustin Dettmer describes some nice ideas in that thread. We've been > trashing around similar approaches since years. > > > On 13/03/2019 20.30, Oscar Guindzberg wrote: > > Ok, how would you improve reject messages? > > > > Just for the record here is the link of a recent bitcoin-dev list > > proposal to remove reject messages > > https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016701.html > > . Andreas replied suggesting to keep the "reject" messages. > > > > > > On Wed, Mar 13, 2019 at 1:26 PM Andreas Schildbach > > <andr...@schildbach.de> wrote: > >> > >> I think it's in Wallet.setTransactionBroadcaster(), near the end. See > >> the comments there. > >> > >> Yes, I agree it might be inconvenient to re-broadcast only once. Bitcoin > >> Wallet tears everything down if nothing of relevance to the wallet > >> happens for a few minutes, so it was never a serious problem. > >> > >> Your two suggestions sound fine to me, provided that the actual > >> frequencies can be adjusted/disabled. Maybe we can also make better use > >> of 'reject' messages at the same time? > >> > >> > >> On 13/03/2019 16.54, Oscar Guindzberg wrote: > >>> Thanks for the answer. > >>> > >>> I could not find the code that "automatically rebroadcasts all > >>> unconfirmed transactions that are in your wallet once after you start > >>> a connectedPeerGroup and enough peers are connected". Could you point > >>> me to it? > >>> > >>> In any case, that would require a restart of the app to fix a tx that is > >>> stuck. > >>> > >>> I would like a tx to be rebroadcasted automatically if > >>> TransactionBroadcast could not mark the broadcast as complete after > >>> ~10 seconds (maybe more because I kinda heard there might be delays > >>> with nodes running behind tor) and every ~45 minutes if tx was not > >>> mined. > >>> > >>> I can imagine someone already thought about this, but I could not find > >>> any discussion on this subject here nor on the bitcoin-dev mailing > >>> list, but maybe I missed something. > >>> > >>> > >>> On Wed, Mar 13, 2019 at 9:20 AM Andreas Schildbach > >>> <andr...@schildbach.de> wrote: > >>>> > >>>> On 13/03/2019 00.26, Oscar Guindzberg wrote: > >>>> > >>>>> Is there any email thread or doc about what happens when there is a > >>>>> problem on tx broadcast? > >>>>> > >>>>> Maybe discussions about whether bitcoinj should rebroadcast the tx, if > >>>>> that is the user responsibility, when to do the rebroadcast, etc. > >>>> > >>>> Currently bitcoinj automatically rebroadcasts all unconfirmed > >>>> transactions that are in your wallet once after you start a connected > >>>> PeerGroup and enough peers are connected. > >>>> > >>>> Of course if the transaction is (or has become) invalid, that effert is > >>>> in vein. You will need to replay your wallet to get rid of such > >>>> transactions. I'm not aware of further plans on this matter, but feel > >>>> free to share your thoughts. > >>>> > >>>> -- > >>>> You received this message because you are subscribed to the Google > >>>> Groups "bitcoinj" group. > >>>> To unsubscribe from this group and stop receiving emails from it, send > >>>> an email to bitcoinj+unsubscr...@googlegroups.com. > >>>> For more options, visit https://groups.google.com/d/optout. > >>> > >>> > >>> > >>> -- > >>> Oscar Guindzberg > >>> > >> > >> > >> -- > >> You received this message because you are subscribed to the Google Groups > >> "bitcoinj" group. > >> To unsubscribe from this group and stop receiving emails from it, send an > >> email to bitcoinj+unsubscr...@googlegroups.com. > >> For more options, visit https://groups.google.com/d/optout. > > > > > > > > > -- > You received this message because you are subscribed to the Google Groups > "bitcoinj" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to bitcoinj+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Oscar Guindzberg -- You received this message because you are subscribed to the Google Groups "bitcoinj" group. To unsubscribe from this group and stop receiving emails from it, send an email to bitcoinj+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
