It depends on the issue being fixed. Not all Lint warnings are properly fixable, and some are not even desirable to fix (in my eyes).

For this kind of PR, I prefer PRs that refactor a specific issue on the entire repository. Then, the discussion on wether it's an improvement or not can happen in the comments on the PR.


On 14/04/2021 11.13, 'Alan Mehio' via bitcoinj wrote:
Dear all,
It would be nice to hear from you first before I start to make a pull request which will try to fix the java static analysis issues based on SonarLint.
Is there any wish list to todo or SonarLint is OK  to start with first ?


I would like to  receive a feedback from the community

Regards,
Alan

--
You received this message because you are subscribed to the Google Groups "bitcoinj" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected] <mailto:[email protected]>. To view this discussion on the web visit https://groups.google.com/d/msgid/bitcoinj/55052ea9-b970-4e34-b1e9-78bdef4c926bn%40googlegroups.com <https://groups.google.com/d/msgid/bitcoinj/55052ea9-b970-4e34-b1e9-78bdef4c926bn%40googlegroups.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"bitcoinj" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/bitcoinj/f898485a-86a8-a7cc-99a0-aea8b142c3dd%40schildbach.de.

Reply via email to