ChangeSet 1.2182, 2005/03/14 10:02:44-08:00, [EMAIL PROTECTED]

        Merge 2.6.11.3 into mainline



 Makefile                       |   51 ++++++---
 arch/ppc/platforms/4xx/ebony.h |   10 -
 drivers/char/drm/drm_ioctl.c   |   12 +-
 drivers/media/video/adv7170.c  |    5 
 drivers/media/video/adv7175.c  |    5 
 drivers/media/video/bt819.c    |   11 --
 drivers/media/video/saa7110.c  |   15 +-
 drivers/media/video/saa7114.c  |    5 
 drivers/media/video/saa7185.c  |    5 
 drivers/net/r8169.c            |    4 
 drivers/net/sis900.c           |  220 +++++++++++++++++++++++++----------------
 drivers/net/via-rhine.c        |    8 -
 12 files changed, 206 insertions(+), 145 deletions(-)


diff -Nru a/Makefile b/Makefile
--- a/Makefile  2005-03-14 23:10:04 -08:00
+++ b/Makefile  2005-03-14 23:10:04 -08:00
@@ -18,7 +18,7 @@
 #
 # Most importantly: sub-Makefiles should only ever modify files in
 # their own directory. If in some directory we have a dependency on
-# a file in another dir (which doesn't happen often, but it's of
+# a file in another dir (which doesn't happen often, but it's often
 # unavoidable when linking the built-in.o targets which finally
 # turn into vmlinux), we will call a sub make in that other dir, and
 # after that we are sure that everything which is in that other dir
@@ -67,7 +67,7 @@
 
 
 # kbuild supports saving output files in a separate directory.
-# To locate output files in a separate directory two syntax'es are supported.
+# To locate output files in a separate directory two syntaxes are supported.
 # In both cases the working directory must be the root of the kernel src.
 # 1) O=
 # Use "make O=dir/to/store/output/files/"
@@ -78,7 +78,8 @@
 # export KBUILD_OUTPUT=dir/to/store/output/files/
 # make
 #
-# The O= assigment takes precedence over the KBUILD_OUTPUT environment 
variable.
+# The O= assignment takes precedence over the KBUILD_OUTPUT environment
+# variable.
 
 
 # KBUILD_SRC is set on invocation of make in OBJ directory
@@ -539,16 +540,14 @@
 # Default kernel image to build when no specific target is given.
 # KBUILD_IMAGE may be overruled on the commandline or
 # set in the environment
-# Also any assingments in arch/$(ARCH)/Makefiel take precedence over
+# Also any assignments in arch/$(ARCH)/Makefile take precedence over
 # this default value
 export KBUILD_IMAGE ?= vmlinux
 
 #
 # INSTALL_PATH specifies where to place the updated kernel and system map
-# images.  Uncomment if you want to place them anywhere other than root.
-#
-
-#export        INSTALL_PATH=/boot
+# images. Default is /boot, but you can set it to other values
+export INSTALL_PATH ?= /boot
 
 #
 # INSTALL_MOD_PATH specifies a prefix to MODLIB for module directory
@@ -898,7 +897,7 @@
 endif
 .PHONY: _modinst_post
 _modinst_post: _modinst_
-       if [ -r System.map ]; then $(DEPMOD) -ae -F System.map $(depmod_opts) 
$(KERNELRELEASE); fi
+       if [ -r System.map -a -x $(DEPMOD) ]; then $(DEPMOD) -ae -F System.map 
$(depmod_opts) $(KERNELRELEASE); fi
 
 else # CONFIG_MODULES
 
@@ -1096,9 +1095,17 @@
 crmodverdir:
        $(Q)mkdir -p $(MODVERDIR)
 
+.PHONY: $(objtree)/Module.symvers
+$(objtree)/Module.symvers:
+       @test -e $(objtree)/Module.symvers || ( \
+       echo; \
+       echo "  WARNING: Symbol version dump $(objtree)/Module.symvers"; \
+       echo "           is missing; modules will have no dependencies and 
modversions."; \
+       echo )
+
 module-dirs := $(addprefix _module_,$(KBUILD_EXTMOD))
 .PHONY: $(module-dirs) modules
-$(module-dirs): crmodverdir
+$(module-dirs): crmodverdir $(objtree)/Module.symvers
        $(Q)$(MAKE) $(build)=$(patsubst _module_%,%,$@)
 
 modules: $(module-dirs)
@@ -1136,20 +1143,30 @@
 # Generate tags for editors
 # ---------------------------------------------------------------------------
 
+#We want __srctree to totally vanish out when KBUILD_OUTPUT is not set
+#(which is the most common case IMHO) to avoid unneeded clutter in the big 
tags file.
+#Adding $(srctree) adds about 20M on i386 to the size of the output file!
+
+ifeq ($(KBUILD_OUTPUT),)
+__srctree =
+else
+__srctree = $(srctree)/
+endif
+
 define all-sources
-       ( find $(srctree) $(RCS_FIND_IGNORE) \
+       ( find $(__srctree) $(RCS_FIND_IGNORE) \
               \( -name include -o -name arch \) -prune -o \
               -name '*.[chS]' -print; \
-         find $(srctree)/arch/$(ARCH) $(RCS_FIND_IGNORE) \
+         find $(__srctree)arch/$(ARCH) $(RCS_FIND_IGNORE) \
               -name '*.[chS]' -print; \
-         find $(srctree)/security/selinux/include $(RCS_FIND_IGNORE) \
+         find $(__srctree)security/selinux/include $(RCS_FIND_IGNORE) \
               -name '*.[chS]' -print; \
-         find $(srctree)/include $(RCS_FIND_IGNORE) \
+         find $(__srctree)include $(RCS_FIND_IGNORE) \
               \( -name config -o -name 'asm-*' \) -prune \
               -o -name '*.[chS]' -print; \
-         find $(srctree)/include/asm-$(ARCH) $(RCS_FIND_IGNORE) \
+         find $(__srctree)include/asm-$(ARCH) $(RCS_FIND_IGNORE) \
               -name '*.[chS]' -print; \
-         find $(srctree)/include/asm-generic $(RCS_FIND_IGNORE) \
+         find $(__srctree)include/asm-generic $(RCS_FIND_IGNORE) \
               -name '*.[chS]' -print )
 endef
 
@@ -1172,7 +1189,7 @@
 define cmd_tags
        rm -f $@; \
        CTAGSF=`ctags --version | grep -i exuberant >/dev/null && echo "-I 
__initdata,__exitdata,EXPORT_SYMBOL,EXPORT_SYMBOL_GPL"`; \
-       $(all-sources) | xargs ctags $$CTAGSF -a
+       $(all-sources) | xargs ctags $$CTAGSF -a --extra=+f
 endef
 
 TAGS: FORCE
diff -Nru a/arch/ppc/platforms/4xx/ebony.h b/arch/ppc/platforms/4xx/ebony.h
--- a/arch/ppc/platforms/4xx/ebony.h    2005-03-14 23:10:04 -08:00
+++ b/arch/ppc/platforms/4xx/ebony.h    2005-03-14 23:10:04 -08:00
@@ -23,13 +23,9 @@
 /* F/W TLB mapping used in bootloader glue to reset EMAC */
 #define PPC44x_EMAC0_MR0       0xE0000800
 
-/* Macros to get at Ebony VPD info */
-#define EBONY_VPD_BASE         0x00000001fffffe00ULL
-#define EBONY_VPD_SIZE         0x24
-#define EBONY_NA0_OFFSET       0x0c
-#define EBONY_NA1_OFFSET       0x18
-#define EBONY_NA0_ADDR(base)   (base + EBONY_NA0_OFFSET)
-#define EBONY_NA1_ADDR(base)   (base + EBONY_NA1_OFFSET)
+/* Where to find the MAC info */
+#define EBONY_OPENBIOS_MAC_BASE   0xfffffe0c
+#define EBONY_OPENBIOS_MAC_OFFSET 0x0c
 
 /* Default clock rates for Rev. B and Rev. C silicon */
 #define EBONY_440GP_RB_SYSCLK  33000000
diff -Nru a/drivers/char/drm/drm_ioctl.c b/drivers/char/drm/drm_ioctl.c
--- a/drivers/char/drm/drm_ioctl.c      2005-03-14 23:10:04 -08:00
+++ b/drivers/char/drm/drm_ioctl.c      2005-03-14 23:10:04 -08:00
@@ -53,7 +53,7 @@
                   unsigned int cmd, unsigned long arg)
 {
        drm_file_t       *priv   = filp->private_data;
-       drm_device_t     *dev    = priv->dev;
+       drm_device_t     *dev    = priv->head->dev;
        drm_unique_t     __user *argp = (void __user *)arg;
        drm_unique_t     u;
 
@@ -87,7 +87,7 @@
                   unsigned int cmd, unsigned long arg)
 {
        drm_file_t       *priv   = filp->private_data;
-       drm_device_t     *dev    = priv->dev;
+       drm_device_t     *dev    = priv->head->dev;
        drm_unique_t     u;
        int              domain, bus, slot, func, ret;
 
@@ -173,7 +173,7 @@
                 unsigned int cmd, unsigned long arg )
 {
        drm_file_t   *priv = filp->private_data;
-       drm_device_t *dev  = priv->dev;
+       drm_device_t *dev  = priv->head->dev;
        drm_map_t    __user *argp = (void __user *)arg;
        drm_map_t    map;
        drm_map_list_t *r_list = NULL;
@@ -233,7 +233,7 @@
                    unsigned int cmd, unsigned long arg )
 {
        drm_file_t   *priv = filp->private_data;
-       drm_device_t *dev  = priv->dev;
+       drm_device_t *dev  = priv->head->dev;
        drm_client_t __user *argp = (void __user *)arg;
        drm_client_t client;
        drm_file_t   *pt;
@@ -277,7 +277,7 @@
                   unsigned int cmd, unsigned long arg )
 {
        drm_file_t   *priv = filp->private_data;
-       drm_device_t *dev  = priv->dev;
+       drm_device_t *dev  = priv->head->dev;
        drm_stats_t  stats;
        int          i;
 
@@ -325,6 +325,8 @@
        drm_version_t version;
 
        DRM_COPY_FROM_USER_IOCTL(sv, argp, sizeof(sv));
+
+       memset(&version, 0, sizeof(version));
 
        memset(&version, 0, sizeof(version));
 
diff -Nru a/drivers/media/video/adv7170.c b/drivers/media/video/adv7170.c
--- a/drivers/media/video/adv7170.c     2005-03-14 23:10:04 -08:00
+++ b/drivers/media/video/adv7170.c     2005-03-14 23:10:04 -08:00
@@ -402,7 +402,6 @@
        .force                  = force
 };
 
-static int adv7170_i2c_id = 0;
 static struct i2c_driver i2c_driver_adv7170;
 
 static int
@@ -432,7 +431,6 @@
        client->adapter = adapter;
        client->driver = &i2c_driver_adv7170;
        client->flags = I2C_CLIENT_ALLOW_USE;
-       client->id = adv7170_i2c_id++;
        if ((client->addr == I2C_ADV7170 >> 1) ||
            (client->addr == (I2C_ADV7170 >> 1) + 1)) {
                dname = adv7170_name;
@@ -444,8 +442,7 @@
                kfree(client);
                return 0;
        }
-       snprintf(I2C_NAME(client), sizeof(I2C_NAME(client)) - 1,
-               "%s[%d]", dname, client->id);
+       strlcpy(I2C_NAME(client), dname, sizeof(I2C_NAME(client)));
 
        encoder = kmalloc(sizeof(struct adv7170), GFP_KERNEL);
        if (encoder == NULL) {
diff -Nru a/drivers/media/video/adv7175.c b/drivers/media/video/adv7175.c
--- a/drivers/media/video/adv7175.c     2005-03-14 23:10:04 -08:00
+++ b/drivers/media/video/adv7175.c     2005-03-14 23:10:04 -08:00
@@ -452,7 +452,6 @@
        .force                  = force
 };
 
-static int adv7175_i2c_id = 0;
 static struct i2c_driver i2c_driver_adv7175;
 
 static int
@@ -482,7 +481,6 @@
        client->adapter = adapter;
        client->driver = &i2c_driver_adv7175;
        client->flags = I2C_CLIENT_ALLOW_USE;
-       client->id = adv7175_i2c_id++;
        if ((client->addr == I2C_ADV7175 >> 1) ||
            (client->addr == (I2C_ADV7175 >> 1) + 1)) {
                dname = adv7175_name;
@@ -494,8 +492,7 @@
                kfree(client);
                return 0;
        }
-       snprintf(I2C_NAME(client), sizeof(I2C_NAME(client)) - 1,
-               "%s[%d]", dname, client->id);
+       strlcpy(I2C_NAME(client), dname, sizeof(I2C_NAME(client)));
 
        encoder = kmalloc(sizeof(struct adv7175), GFP_KERNEL);
        if (encoder == NULL) {
diff -Nru a/drivers/media/video/bt819.c b/drivers/media/video/bt819.c
--- a/drivers/media/video/bt819.c       2005-03-14 23:10:04 -08:00
+++ b/drivers/media/video/bt819.c       2005-03-14 23:10:04 -08:00
@@ -517,7 +517,6 @@
        .force                  = force
 };
 
-static int bt819_i2c_id = 0;
 static struct i2c_driver i2c_driver_bt819;
 
 static int
@@ -546,7 +545,6 @@
        client->adapter = adapter;
        client->driver = &i2c_driver_bt819;
        client->flags = I2C_CLIENT_ALLOW_USE;
-       client->id = bt819_i2c_id++;
 
        decoder = kmalloc(sizeof(struct bt819), GFP_KERNEL);
        if (decoder == NULL) {
@@ -568,16 +566,13 @@
        id = bt819_read(client, 0x17);
        switch (id & 0xf0) {
        case 0x70:
-               snprintf(I2C_NAME(client), sizeof(I2C_NAME(client)) - 1,
-                        "bt819a[%d]", client->id);
+               strlcpy(I2C_NAME(client), "bt819a", sizeof(I2C_NAME(client)));
                break;
        case 0x60:
-               snprintf(I2C_NAME(client), sizeof(I2C_NAME(client)) - 1,
-                        "bt817a[%d]", client->id);
+               strlcpy(I2C_NAME(client), "bt817a", sizeof(I2C_NAME(client)));
                break;
        case 0x20:
-               snprintf(I2C_NAME(client), sizeof(I2C_NAME(client)) - 1,
-                        "bt815a[%d]", client->id);
+               strlcpy(I2C_NAME(client), "bt815a", sizeof(I2C_NAME(client)));
                break;
        default:
                dprintk(1,
diff -Nru a/drivers/media/video/saa7110.c b/drivers/media/video/saa7110.c
--- a/drivers/media/video/saa7110.c     2005-03-14 23:10:04 -08:00
+++ b/drivers/media/video/saa7110.c     2005-03-14 23:10:04 -08:00
@@ -30,6 +30,7 @@
 #include <linux/types.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
+#include <linux/wait.h>
 #include <asm/io.h>
 #include <asm/uaccess.h>
 
@@ -204,13 +205,16 @@
 static int
 determine_norm (struct i2c_client *client)
 {
+       DEFINE_WAIT(wait);
        struct saa7110 *decoder = i2c_get_clientdata(client);
        int status;
 
        /* mode changed, start automatic detection */
        saa7110_write_block(client, initseq, sizeof(initseq));
        saa7110_selmux(client, decoder->input);
-       sleep_on_timeout(&decoder->wq, HZ / 4);
+       prepare_to_wait(&decoder->wq, &wait, TASK_UNINTERRUPTIBLE);
+       schedule_timeout(HZ/4);
+       finish_wait(&decoder->wq, &wait);
        status = saa7110_read(client);
        if (status & 0x40) {
                dprintk(1, KERN_INFO "%s: status=0x%02x (no signal)\n",
@@ -249,7 +253,9 @@
        saa7110_write(client, 0x11, 0x59);
        //saa7110_write(client,0x2E,0x9A);
 
-       sleep_on_timeout(&decoder->wq, HZ / 4);
+       prepare_to_wait(&decoder->wq, &wait, TASK_UNINTERRUPTIBLE);
+       schedule_timeout(HZ/4);
+       finish_wait(&decoder->wq, &wait);
 
        status = saa7110_read(client);
        if ((status & 0x03) == 0x01) {
@@ -475,7 +481,6 @@
        .force                  = force
 };
 
-static int saa7110_i2c_id = 0;
 static struct i2c_driver i2c_driver_saa7110;
 
 static int
@@ -506,9 +511,7 @@
        client->adapter = adapter;
        client->driver = &i2c_driver_saa7110;
        client->flags = I2C_CLIENT_ALLOW_USE;
-       client->id = saa7110_i2c_id++;
-       snprintf(I2C_NAME(client), sizeof(I2C_NAME(client)) - 1,
-               "saa7110[%d]", client->id);
+       strlcpy(I2C_NAME(client), "saa7110", sizeof(I2C_NAME(client)));
 
        decoder = kmalloc(sizeof(struct saa7110), GFP_KERNEL);
        if (decoder == 0) {
diff -Nru a/drivers/media/video/saa7114.c b/drivers/media/video/saa7114.c
--- a/drivers/media/video/saa7114.c     2005-03-14 23:10:04 -08:00
+++ b/drivers/media/video/saa7114.c     2005-03-14 23:10:04 -08:00
@@ -838,7 +838,6 @@
        .force                  = force
 };
 
-static int saa7114_i2c_id = 0;
 static struct i2c_driver i2c_driver_saa7114;
 
 static int
@@ -871,9 +870,7 @@
        client->adapter = adapter;
        client->driver = &i2c_driver_saa7114;
        client->flags = I2C_CLIENT_ALLOW_USE;
-       client->id = saa7114_i2c_id++;
-       snprintf(I2C_NAME(client), sizeof(I2C_NAME(client)) - 1,
-               "saa7114[%d]", client->id);
+       strlcpy(I2C_NAME(client), "saa7114", sizeof(I2C_NAME(client)));
 
        decoder = kmalloc(sizeof(struct saa7114), GFP_KERNEL);
        if (decoder == NULL) {
diff -Nru a/drivers/media/video/saa7185.c b/drivers/media/video/saa7185.c
--- a/drivers/media/video/saa7185.c     2005-03-14 23:10:04 -08:00
+++ b/drivers/media/video/saa7185.c     2005-03-14 23:10:04 -08:00
@@ -398,7 +398,6 @@
        .force                  = force
 };
 
-static int saa7185_i2c_id = 0;
 static struct i2c_driver i2c_driver_saa7185;
 
 static int
@@ -427,9 +426,7 @@
        client->adapter = adapter;
        client->driver = &i2c_driver_saa7185;
        client->flags = I2C_CLIENT_ALLOW_USE;
-       client->id = saa7185_i2c_id++;
-       snprintf(I2C_NAME(client), sizeof(I2C_NAME(client)) - 1,
-               "saa7185[%d]", client->id);
+       strlcpy(I2C_NAME(client), "saa7185", sizeof(I2C_NAME(client)));
 
        encoder = kmalloc(sizeof(struct saa7185), GFP_KERNEL);
        if (encoder == NULL) {
diff -Nru a/drivers/net/r8169.c b/drivers/net/r8169.c
--- a/drivers/net/r8169.c       2005-03-14 23:10:04 -08:00
+++ b/drivers/net/r8169.c       2005-03-14 23:10:04 -08:00
@@ -1180,7 +1180,7 @@
        /* enable device (incl. PCI PM wakeup and hotplug setup) */
        rc = pci_enable_device(pdev);
        if (rc) {
-               printk(KERN_ERR PFX "%s: enable failure\n", pdev->slot_name);
+               printk(KERN_ERR PFX "%s: enable failure\n", pci_name(pdev));
                goto err_out_free_dev;
        }
 
@@ -1218,7 +1218,7 @@
        rc = pci_request_regions(pdev, MODULENAME);
        if (rc) {
                printk(KERN_ERR PFX "%s: could not request regions.\n",
-                      pdev->slot_name);
+                      pci_name(pdev));
                goto err_out_mwi;
        }
 
diff -Nru a/drivers/net/sis900.c b/drivers/net/sis900.c
--- a/drivers/net/sis900.c      2005-03-14 23:10:04 -08:00
+++ b/drivers/net/sis900.c      2005-03-14 23:10:04 -08:00
@@ -1,6 +1,6 @@
 /* sis900.c: A SiS 900/7016 PCI Fast Ethernet driver for Linux.
    Copyright 1999 Silicon Integrated System Corporation 
-   Revision:   1.08.06 Sep. 24 2002
+   Revision:   1.08.08 Jan. 22 2005
    
    Modified from the driver which is originally written by Donald Becker.
    
@@ -16,8 +16,8 @@
    preliminary Rev. 1.0 Nov. 10, 1998
    SiS 7014 Single Chip 100BASE-TX/10BASE-T Physical Layer Solution,
    preliminary Rev. 1.0 Jan. 18, 1998
-   http://www.sis.com.tw/support/databook.htm
 
+   Rev 1.08.08 Jan. 22 2005 Daniele Venzano use netif_msg for debugging 
messages
    Rev 1.08.07 Nov.  2 2003 Daniele Venzano <[EMAIL PROTECTED]> add 
suspend/resume support
    Rev 1.08.06 Sep. 24 2002 Mufasa Yang bug fix for Tx timeout & add SiS963 
support
    Rev 1.08.05 Jun.  6 2002 Mufasa Yang bug fix for read_eeprom & Tx 
descriptor over-boundary
@@ -69,12 +69,13 @@
 
 #include <asm/processor.h>      /* Processor type for cache alignment. */
 #include <asm/io.h>
+#include <asm/irq.h>
 #include <asm/uaccess.h>       /* User space memory access functions */
 
 #include "sis900.h"
 
 #define SIS900_MODULE_NAME "sis900"
-#define SIS900_DRV_VERSION "v1.08.07 11/02/2003"
+#define SIS900_DRV_VERSION "v1.08.08 Jan. 22 2005"
 
 static char version[] __devinitdata =
 KERN_INFO "sis900.c: " SIS900_DRV_VERSION "\n";
@@ -82,8 +83,13 @@
 static int max_interrupt_work = 40;
 static int multicast_filter_limit = 128;
 
-#define sis900_debug debug
-static int sis900_debug;
+static int sis900_debug = -1; /* Use SIS900_DEF_MSG as value */
+
+#define SIS900_DEF_MSG \
+       (NETIF_MSG_DRV          | \
+        NETIF_MSG_LINK         | \
+        NETIF_MSG_RX_ERR       | \
+        NETIF_MSG_TX_ERR)
 
 /* Time in jiffies before concluding the transmitter is hung. */
 #define TX_TIMEOUT  (4*HZ)
@@ -160,6 +166,8 @@
        struct timer_list timer; /* Link status detection timer. */
        u8 autong_complete; /* 1: auto-negotiate complete  */
 
+       u32 msg_enable;
+
        unsigned int cur_rx, dirty_rx; /* producer/comsumer pointers for Tx/Rx 
ring */
        unsigned int cur_tx, dirty_tx;
 
@@ -174,6 +182,7 @@
 
        unsigned int tx_full; /* The Tx queue is full. */
        u8 host_bridge_rev;
+       u8 chipset_rev;
 };
 
 MODULE_AUTHOR("Jim Huang <[EMAIL PROTECTED]>, Ollie Lho <[EMAIL PROTECTED]>");
@@ -182,11 +191,12 @@
 
 module_param(multicast_filter_limit, int, 0444);
 module_param(max_interrupt_work, int, 0444);
-module_param(debug, int, 0444);
+module_param(sis900_debug, int, 0444);
 MODULE_PARM_DESC(multicast_filter_limit, "SiS 900/7016 maximum number of 
filtered multicast addresses");
 MODULE_PARM_DESC(max_interrupt_work, "SiS 900/7016 maximum events handled per 
interrupt");
-MODULE_PARM_DESC(debug, "SiS 900/7016 debug level (2-4)");
+MODULE_PARM_DESC(sis900_debug, "SiS 900/7016 bitmapped debugging message 
level");
 
+static void sis900_poll(struct net_device *dev);
 static int sis900_open(struct net_device *net_dev);
 static int sis900_mii_probe (struct net_device * net_dev);
 static void sis900_init_rxfilter (struct net_device * net_dev);
@@ -235,7 +245,7 @@
        /* check to see if we have sane EEPROM */
        signature = (u16) read_eeprom(ioaddr, EEPROMSignature);    
        if (signature == 0xffff || signature == 0x0000) {
-               printk (KERN_INFO "%s: Error EERPOM read %x\n", 
+               printk (KERN_WARNING "%s: Error EERPOM read %x\n", 
                        pci_name(pci_dev), signature);
                return 0;
        }
@@ -268,7 +278,8 @@
        if (!isa_bridge)
                isa_bridge = pci_get_device(PCI_VENDOR_ID_SI, 0x0018, 
isa_bridge);
        if (!isa_bridge) {
-               printk("%s: Can not find ISA bridge\n", pci_name(pci_dev));
+               printk(KERN_WARNING "%s: Can not find ISA bridge\n",
+                      pci_name(pci_dev));
                return 0;
        }
        pci_read_config_byte(isa_bridge, 0x48, &reg);
@@ -386,8 +397,8 @@
        void *ring_space;
        long ioaddr;
        int i, ret;
-       u8 revision;
        char *card_name = card_names[pci_id->driver_data];
+       const char *dev_name = pci_name(pci_dev);
 
 /* when built into the kernel, we only print version if device is found */
 #ifndef MODULE
@@ -456,31 +467,47 @@
        net_dev->tx_timeout = sis900_tx_timeout;
        net_dev->watchdog_timeo = TX_TIMEOUT;
        net_dev->ethtool_ops = &sis900_ethtool_ops;
+
+#ifdef CONFIG_NET_POLL_CONTROLLER
+        net_dev->poll_controller = &sis900_poll;
+#endif
+
+       if (sis900_debug > 0)
+               sis_priv->msg_enable = sis900_debug;
+       else
+               sis_priv->msg_enable = SIS900_DEF_MSG;
                
        /* Get Mac address according to the chip revision */
-       pci_read_config_byte(pci_dev, PCI_CLASS_REVISION, &revision);
+       pci_read_config_byte(pci_dev, PCI_CLASS_REVISION, 
&(sis_priv->chipset_rev));
+       if(netif_msg_probe(sis_priv))
+               printk(KERN_DEBUG "%s: detected revision %2.2x, "
+                               "trying to get MAC address...\n",
+                               dev_name, sis_priv->chipset_rev);
+       
        ret = 0;
-
-       if (revision == SIS630E_900_REV)
+       if (sis_priv->chipset_rev == SIS630E_900_REV)
                ret = sis630e_get_mac_addr(pci_dev, net_dev);
-       else if ((revision > 0x81) && (revision <= 0x90) )
+       else if ((sis_priv->chipset_rev > 0x81) && (sis_priv->chipset_rev <= 
0x90) )
                ret = sis635_get_mac_addr(pci_dev, net_dev);
-       else if (revision == SIS96x_900_REV)
+       else if (sis_priv->chipset_rev == SIS96x_900_REV)
                ret = sis96x_get_mac_addr(pci_dev, net_dev);
        else
                ret = sis900_get_mac_addr(pci_dev, net_dev);
 
        if (ret == 0) {
+               printk(KERN_WARNING "%s: Cannot read MAC address.\n", dev_name);
                ret = -ENODEV;
                goto err_unmap_rx;
        }
        
        /* 630ET : set the mii access mode as software-mode */
-       if (revision == SIS630ET_900_REV)
+       if (sis_priv->chipset_rev == SIS630ET_900_REV)
                outl(ACCESSMODE | inl(ioaddr + cr), ioaddr + cr);
 
        /* probe for mii transceiver */
        if (sis900_mii_probe(net_dev) == 0) {
+               printk(KERN_WARNING "%s: Error probing MII device.\n",
+                      dev_name);
                ret = -ENODEV;
                goto err_unmap_rx;
        }
@@ -535,7 +562,6 @@
        u16 poll_bit = MII_STAT_LINK, status = 0;
        unsigned long timeout = jiffies + 5 * HZ;
        int phy_addr;
-       u8 revision;
 
        sis_priv->mii = NULL;
 
@@ -549,12 +575,16 @@
                for(i = 0; i < 2; i++)
                        mii_status = mdio_read(net_dev, phy_addr, MII_STATUS);
 
-               if (mii_status == 0xffff || mii_status == 0x0000)
-                       /* the mii is not accessible, try next one */
+               if (mii_status == 0xffff || mii_status == 0x0000) {
+                       if (netif_msg_probe(sis_priv))
+                               printk(KERN_DEBUG "%s: MII at address %d"
+                                               " not accessible\n",
+                                               dev_name, phy_addr);
                        continue;
+               }
                
                if ((mii_phy = kmalloc(sizeof(struct mii_phy), GFP_KERNEL)) == 
NULL) {
-                       printk(KERN_INFO "Cannot allocate mem for struct 
mii_phy\n");
+                       printk(KERN_WARNING "Cannot allocate mem for struct 
mii_phy\n");
                        mii_phy = sis_priv->first_mii;
                        while (mii_phy) {
                                struct mii_phy *phy;
@@ -580,9 +610,11 @@
                                if (mii_chip_table[i].phy_types == MIX)
                                        mii_phy->phy_types =
                                            (mii_status & (MII_STAT_CAN_TX_FDX 
| MII_STAT_CAN_TX)) ? LAN : HOME;
-                               printk(KERN_INFO "%s: %s transceiver found at 
address %d.\n",
-                                      dev_name, mii_chip_table[i].name,
-                                      phy_addr);
+                               printk(KERN_INFO "%s: %s transceiver found "
+                                                       "at address %d.\n",
+                                                       dev_name,
+                                                       mii_chip_table[i].name,
+                                                       phy_addr);
                                break;
                        }
                        
@@ -625,8 +657,7 @@
                }
        }
 
-       pci_read_config_byte(sis_priv->pci_dev, PCI_CLASS_REVISION, &revision);
-       if (revision == SIS630E_900_REV) {
+       if (sis_priv->chipset_rev == SIS630E_900_REV) {
                /* SiS 630E has some bugs on default value of PHY registers */
                mdio_write(net_dev, sis_priv->cur_phy, MII_ANADV, 0x05e1);
                mdio_write(net_dev, sis_priv->cur_phy, MII_CONFIG1, 0x22);
@@ -928,6 +959,20 @@
        return status;
 }
 
+#ifdef CONFIG_NET_POLL_CONTROLLER
+/*
+ * Polling 'interrupt' - used by things like netconsole to send skbs
+ * without having to re-enable interrupts. It's not called while
+ * the interrupt routine is executing.
+*/
+static void sis900_poll(struct net_device *dev)
+{
+       disable_irq(dev->irq);
+       sis900_interrupt(dev->irq, dev, NULL);
+       enable_irq(dev->irq);
+}
+#endif
+
 /**
  *     sis900_open - open sis900 device
  *     @net_dev: the net device to open
@@ -941,15 +986,13 @@
 {
        struct sis900_private *sis_priv = net_dev->priv;
        long ioaddr = net_dev->base_addr;
-       u8 revision;
        int ret;
 
        /* Soft reset the chip. */
        sis900_reset(net_dev);
 
        /* Equalizer workaround Rule */
-       pci_read_config_byte(sis_priv->pci_dev, PCI_CLASS_REVISION, &revision);
-       sis630_set_eq(net_dev, revision);
+       sis630_set_eq(net_dev, sis_priv->chipset_rev);
 
        ret = request_irq(net_dev->irq, &sis900_interrupt, SA_SHIRQ,
                                                net_dev->name, net_dev);
@@ -997,6 +1040,7 @@
 static void
 sis900_init_rxfilter (struct net_device * net_dev)
 {
+       struct sis900_private *sis_priv = net_dev->priv;
        long ioaddr = net_dev->base_addr;
        u32 rfcrSave;
        u32 i;
@@ -1014,8 +1058,8 @@
                outl((i << RFADDR_shift), ioaddr + rfcr);
                outl(w, ioaddr + rfdr);
 
-               if (sis900_debug > 2) {
-                       printk(KERN_INFO "%s: Receive Filter Addrss[%d]=%x\n",
+               if (netif_msg_hw(sis_priv)) {
+                       printk(KERN_DEBUG "%s: Receive Filter Addrss[%d]=%x\n",
                               net_dev->name, i, inl(ioaddr + rfdr));
                }
        }
@@ -1052,8 +1096,8 @@
 
        /* load Transmit Descriptor Register */
        outl(sis_priv->tx_ring_dma, ioaddr + txdp);
-       if (sis900_debug > 2)
-               printk(KERN_INFO "%s: TX descriptor register loaded with: 
%8.8x\n",
+       if (netif_msg_hw(sis_priv))
+               printk(KERN_DEBUG "%s: TX descriptor register loaded with: 
%8.8x\n",
                       net_dev->name, inl(ioaddr + txdp));
 }
 
@@ -1106,8 +1150,8 @@
 
        /* load Receive Descriptor Register */
        outl(sis_priv->rx_ring_dma, ioaddr + rxdp);
-       if (sis900_debug > 2)
-               printk(KERN_INFO "%s: RX descriptor register loaded with: 
%8.8x\n",
+       if (netif_msg_hw(sis_priv))
+               printk(KERN_DEBUG "%s: RX descriptor register loaded with: 
%8.8x\n",
                       net_dev->name, inl(ioaddr + rxdp));
 }
 
@@ -1217,7 +1261,6 @@
        struct mii_phy *mii_phy = sis_priv->mii;
        static int next_tick = 5*HZ;
        u16 status;
-       u8 revision;
 
        if (!sis_priv->autong_complete){
                int speed, duplex = 0;
@@ -1225,9 +1268,7 @@
                sis900_read_mode(net_dev, &speed, &duplex);
                if (duplex){
                        sis900_set_mode(net_dev->base_addr, speed, duplex);
-                       pci_read_config_byte(sis_priv->pci_dev,
-                                               PCI_CLASS_REVISION, &revision);
-                       sis630_set_eq(net_dev, revision);
+                       sis630_set_eq(net_dev, sis_priv->chipset_rev);
                        netif_start_queue(net_dev);
                }
 
@@ -1254,16 +1295,15 @@
        /* Link ON -> OFF */
                 if (!(status & MII_STAT_LINK)){
                        netif_carrier_off(net_dev);
-                       printk(KERN_INFO "%s: Media Link Off\n", net_dev->name);
+                       if(netif_msg_link(sis_priv))
+                               printk(KERN_INFO "%s: Media Link Off\n", 
net_dev->name);
 
                        /* Change mode issue */
                        if ((mii_phy->phy_id0 == 0x001D) && 
                            ((mii_phy->phy_id1 & 0xFFF0) == 0x8000))
                                        sis900_reset_phy(net_dev,  
sis_priv->cur_phy);
   
-                       pci_read_config_byte(sis_priv->pci_dev,
-                                       PCI_CLASS_REVISION, &revision);
-                       sis630_set_eq(net_dev, revision);
+                       sis630_set_eq(net_dev, sis_priv->chipset_rev);
   
                        goto LookForLink;
                 }
@@ -1369,7 +1409,8 @@
                status = mdio_read(net_dev, phy_addr, MII_STATUS);
 
        if (!(status & MII_STAT_LINK)){
-               printk(KERN_INFO "%s: Media Link Off\n", net_dev->name);
+               if(netif_msg_link(sis_priv))
+                       printk(KERN_INFO "%s: Media Link Off\n", net_dev->name);
                sis_priv->autong_complete = 1;
                netif_carrier_off(net_dev);
                return;
@@ -1431,7 +1472,8 @@
                        *speed = HW_SPEED_100_MBPS;
        }
 
-       printk(KERN_INFO "%s: Media Link On %s %s-duplex \n",
+       if(netif_msg_link(sis_priv))
+               printk(KERN_INFO "%s: Media Link On %s %s-duplex \n",
                                        net_dev->name,
                                        *speed == HW_SPEED_100_MBPS ?
                                                "100mbps" : "10mbps",
@@ -1454,8 +1496,9 @@
        unsigned long flags;
        int i;
 
-       printk(KERN_INFO "%s: Transmit timeout, status %8.8x %8.8x \n",
-              net_dev->name, inl(ioaddr + cr), inl(ioaddr + isr));
+       if(netif_msg_tx_err(sis_priv))
+               printk(KERN_INFO "%s: Transmit timeout, status %8.8x %8.8x \n",
+                       net_dev->name, inl(ioaddr + cr), inl(ioaddr + isr));
 
        /* Disable interrupts by clearing the interrupt mask. */
        outl(0x0000, ioaddr + imr);
@@ -1556,8 +1599,8 @@
 
        net_dev->trans_start = jiffies;
 
-       if (sis900_debug > 3)
-               printk(KERN_INFO "%s: Queued Tx packet at %p size %d "
+       if (netif_msg_tx_queued(sis_priv))
+               printk(KERN_DEBUG "%s: Queued Tx packet at %p size %d "
                       "to slot %d.\n",
                       net_dev->name, skb->data, (int)skb->len, entry);
 
@@ -1604,20 +1647,22 @@
 
                /* something strange happened !!! */
                if (status & HIBERR) {
-                       printk(KERN_INFO "%s: Abnormal interrupt,"
-                              "status %#8.8x.\n", net_dev->name, status);
+                       if(netif_msg_intr(sis_priv))
+                               printk(KERN_INFO "%s: Abnormal interrupt,"
+                                       "status %#8.8x.\n", net_dev->name, 
status);
                        break;
                }
                if (--boguscnt < 0) {
-                       printk(KERN_INFO "%s: Too much work at interrupt, "
-                              "interrupt status = %#8.8x.\n",
-                              net_dev->name, status);
+                       if(netif_msg_intr(sis_priv))
+                               printk(KERN_INFO "%s: Too much work at 
interrupt, "
+                                       "interrupt status = %#8.8x.\n",
+                                       net_dev->name, status);
                        break;
                }
        } while (1);
 
-       if (sis900_debug > 3)
-               printk(KERN_INFO "%s: exiting interrupt, "
+       if(netif_msg_intr(sis_priv))
+               printk(KERN_DEBUG "%s: exiting interrupt, "
                       "interrupt status = 0x%#8.8x.\n",
                       net_dev->name, inl(ioaddr + isr));
        
@@ -1642,8 +1687,8 @@
        unsigned int entry = sis_priv->cur_rx % NUM_RX_DESC;
        u32 rx_status = sis_priv->rx_ring[entry].cmdsts;
 
-       if (sis900_debug > 3)
-               printk(KERN_INFO "sis900_rx, cur_rx:%4.4d, dirty_rx:%4.4d "
+       if (netif_msg_rx_status(sis_priv))
+               printk(KERN_DEBUG "sis900_rx, cur_rx:%4.4d, dirty_rx:%4.4d "
                       "status:0x%8.8x\n",
                       sis_priv->cur_rx, sis_priv->dirty_rx, rx_status);
 
@@ -1654,8 +1699,8 @@
 
                if (rx_status & 
(ABORT|OVERRUN|TOOLONG|RUNT|RXISERR|CRCERR|FAERR)) {
                        /* corrupted packet received */
-                       if (sis900_debug > 3)
-                               printk(KERN_INFO "%s: Corrupted packet "
+                       if (netif_msg_rx_err(sis_priv))
+                               printk(KERN_DEBUG "%s: Corrupted packet "
                                       "received, buffer status = 0x%8.8x.\n",
                                       net_dev->name, rx_status);
                        sis_priv->stats.rx_errors++;
@@ -1676,9 +1721,10 @@
                           some unknow bugs, it is possible that
                           we are working on NULL sk_buff :-( */
                        if (sis_priv->rx_skbuff[entry] == NULL) {
-                               printk(KERN_INFO "%s: NULL pointer " 
-                                      "encountered in Rx ring, skipping\n",
-                                      net_dev->name);
+                               if (netif_msg_rx_err(sis_priv))
+                                       printk(KERN_INFO "%s: NULL pointer " 
+                                               "encountered in Rx ring, 
skipping\n",
+                                               net_dev->name);
                                break;
                        }
 
@@ -1705,9 +1751,10 @@
                                 * "hole" on the buffer ring, it is not clear
                                 * how the hardware will react to this kind
                                 * of degenerated buffer */
-                               printk(KERN_INFO "%s: Memory squeeze,"
-                                      "deferring packet.\n",
-                                      net_dev->name);
+                               if (netif_msg_rx_status(sis_priv))
+                                       printk(KERN_INFO "%s: Memory squeeze,"
+                                               "deferring packet.\n",
+                                               net_dev->name);
                                sis_priv->rx_skbuff[entry] = NULL;
                                /* reset buffer descriptor state */
                                sis_priv->rx_ring[entry].cmdsts = 0;
@@ -1741,9 +1788,10 @@
                                 * "hole" on the buffer ring, it is not clear
                                 * how the hardware will react to this kind
                                 * of degenerated buffer */
-                               printk(KERN_INFO "%s: Memory squeeze,"
-                                      "deferring packet.\n",
-                                      net_dev->name);
+                               if (netif_msg_rx_err(sis_priv))
+                                       printk(KERN_INFO "%s: Memory squeeze,"
+                                               "deferring packet.\n",
+                                               net_dev->name);
                                sis_priv->stats.rx_dropped++;
                                break;
                        }
@@ -1792,8 +1840,8 @@
 
                if (tx_status & (ABORT | UNDERRUN | OWCOLL)) {
                        /* packet unsuccessfully transmitted */
-                       if (sis900_debug > 3)
-                               printk(KERN_INFO "%s: Transmit "
+                       if (netif_msg_tx_err(sis_priv))
+                               printk(KERN_DEBUG "%s: Transmit "
                                       "error, Tx status %8.8x.\n",
                                       net_dev->name, tx_status);
                        sis_priv->stats.tx_errors++;
@@ -1904,8 +1952,22 @@
        strcpy (info->bus_info, pci_name(sis_priv->pci_dev));
 }
 
+static u32 sis900_get_msglevel(struct net_device *net_dev)
+{
+       struct sis900_private *sis_priv = net_dev->priv;
+       return sis_priv->msg_enable;
+}
+  
+static void sis900_set_msglevel(struct net_device *net_dev, u32 value)
+{
+       struct sis900_private *sis_priv = net_dev->priv;
+       sis_priv->msg_enable = value;
+}
+
 static struct ethtool_ops sis900_ethtool_ops = {
-       .get_drvinfo =          sis900_get_drvinfo,
+       .get_drvinfo    = sis900_get_drvinfo,
+       .get_msglevel   = sis900_get_msglevel,
+       .set_msglevel   = sis900_set_msglevel,
 };
 
 /**
@@ -2046,12 +2108,10 @@
                case IF_PORT_AUI: /* AUI */
                case IF_PORT_100BASEFX: /* 100BaseFx */
                        /* These Modes are not supported (are they?)*/
-                       printk(KERN_INFO "Not supported");
                        return -EOPNOTSUPP;
                        break;
             
                default:
-                       printk(KERN_INFO "Invalid");
                        return -EINVAL;
                }
        }
@@ -2097,11 +2157,10 @@
        u16 mc_filter[16] = {0};        /* 256/128 bits multicast hash table */
        int i, table_entries;
        u32 rx_mode;
-       u8 revision;
 
        /* 635 Hash Table entires = 256(2^16) */
-       pci_read_config_byte(sis_priv->pci_dev, PCI_CLASS_REVISION, &revision);
-       if((revision >= SIS635A_900_REV) || (revision == SIS900B_900_REV))
+       if((sis_priv->chipset_rev >= SIS635A_900_REV) ||
+                       (sis_priv->chipset_rev == SIS900B_900_REV))
                table_entries = 16;
        else
                table_entries = 8;
@@ -2127,7 +2186,7 @@
                        mclist && i < net_dev->mc_count;
                        i++, mclist = mclist->next) {
                        unsigned int bit_nr =
-                               sis900_mcast_bitnr(mclist->dmi_addr, revision);
+                               sis900_mcast_bitnr(mclist->dmi_addr, 
sis_priv->chipset_rev);
                        mc_filter[bit_nr >> 4] |= (1 << (bit_nr & 0xf));
                }
        }
@@ -2173,7 +2232,6 @@
        long ioaddr = net_dev->base_addr;
        int i = 0;
        u32 status = TxRCMP | RxRCMP;
-       u8  revision;
 
        outl(0, ioaddr + ier);
        outl(0, ioaddr + imr);
@@ -2186,8 +2244,8 @@
                status ^= (inl(isr + ioaddr) & status);
        }
 
-       pci_read_config_byte(sis_priv->pci_dev, PCI_CLASS_REVISION, &revision);
-       if( (revision >= SIS635A_900_REV) || (revision == SIS900B_900_REV) )
+       if( (sis_priv->chipset_rev >= SIS635A_900_REV) ||
+                       (sis_priv->chipset_rev == SIS900B_900_REV) )
                outl(PESEL | RND_CNT, ioaddr + cfg);
        else
                outl(PESEL, ioaddr + cfg);
@@ -2224,7 +2282,7 @@
 
 #ifdef CONFIG_PM
 
-static int sis900_suspend(struct pci_dev *pci_dev, u32 state)
+static int sis900_suspend(struct pci_dev *pci_dev, pm_message_t state)
 {
        struct net_device *net_dev = pci_get_drvdata(pci_dev);
        long ioaddr = net_dev->base_addr;
diff -Nru a/drivers/net/via-rhine.c b/drivers/net/via-rhine.c
--- a/drivers/net/via-rhine.c   2005-03-14 23:10:04 -08:00
+++ b/drivers/net/via-rhine.c   2005-03-14 23:10:04 -08:00
@@ -390,7 +390,7 @@
 
 #ifdef USE_MMIO
 /* Registers we check that mmio and reg are the same. */
-int mmio_verify_registers[] = {
+static const int mmio_verify_registers[] = {
        RxConfig, TxConfig, IntrEnable, ConfigA, ConfigB, ConfigC, ConfigD,
        0
 };
@@ -1197,8 +1197,10 @@
                       dev->name, rp->pdev->irq);
 
        rc = alloc_ring(dev);
-       if (rc)
+       if (rc) {
+               free_irq(rp->pdev->irq, dev);
                return rc;
+       }
        alloc_rbufs(dev);
        alloc_tbufs(dev);
        rhine_chip_reset(dev);
@@ -1940,7 +1942,7 @@
 }
 
 #ifdef CONFIG_PM
-static int rhine_suspend(struct pci_dev *pdev, u32 state)
+static int rhine_suspend(struct pci_dev *pdev, pm_message_t state)
 {
        struct net_device *dev = pci_get_drvdata(pdev);
        struct rhine_private *rp = netdev_priv(dev);
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to