ChangeSet 1.2247, 2005/03/18 13:32:35-08:00, [EMAIL PROTECTED]
[PATCH] ppc32: Fix a warning in planb video driver
[ aside: This has been sitting in the linuxppc-2.5 bk tree for I don't
know how long. And the driver is still horribly broken. ]
The following patch moves overlay_is_active to before its first use. It
was originally written when gcc wouldn't complain, but now does, about
not
having the definition before usage.
Signed-off-by: Tom Rini <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
planb.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff -Nru a/drivers/media/video/planb.c b/drivers/media/video/planb.c
--- a/drivers/media/video/planb.c 2005-03-18 14:12:30 -08:00
+++ b/drivers/media/video/planb.c 2005-03-18 14:12:30 -08:00
@@ -422,6 +422,16 @@
/* overlay support functions */
/*****************************/
+static inline int overlay_is_active(struct planb *pb)
+{
+ unsigned int size = pb->tab_size * sizeof(struct dbdma_cmd);
+ unsigned int caddr = (unsigned)in_le32(&pb->planb_base->ch1.cmdptr);
+
+ return (in_le32(&pb->overlay_last1->cmd_dep) == pb->ch1_cmd_phys)
+ && (caddr < (pb->ch1_cmd_phys + size))
+ && (caddr >= (unsigned)pb->ch1_cmd_phys);
+}
+
static void overlay_start(struct planb *pb)
{
@@ -852,16 +862,6 @@
};
#define PLANB_PALETTE_MAX 15
-
-static inline int overlay_is_active(struct planb *pb)
-{
- unsigned int size = pb->tab_size * sizeof(struct dbdma_cmd);
- unsigned int caddr = (unsigned)in_le32(&pb->planb_base->ch1.cmdptr);
-
- return (in_le32(&pb->overlay_last1->cmd_dep) == pb->ch1_cmd_phys)
- && (caddr < (pb->ch1_cmd_phys + size))
- && (caddr >= (unsigned)pb->ch1_cmd_phys);
-}
static int vgrab(struct planb *pb, struct video_mmap *mp)
{
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
