ChangeSet 1.2231.1.74, 2005/03/28 19:37:10-08:00, [EMAIL PROTECTED]
[PATCH] x86_64: Fix NMI RTC access race
Fix NMI RTC access race
This patch fixes a race between the CMOS clock setting and the NMI
code. The
NMI code indiscriminatly sets index registers and values in the same
place the
CMOS clock is set. If you are setting the CMOS clock and an NMI
occurs, Bad
values could be written to or read from the CMOS RAM, or the NMI
operation
might not occur correctly.
Resetting the NMI is not required on x86_64 (in fact, it should not be
done
according to the ICH5 documentation). This patch simply removes the
useless
code.
Signed-off-by: Corey Minyard <[EMAIL PROTECTED]>
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
traps.c | 9 ---------
1 files changed, 9 deletions(-)
diff -Nru a/arch/x86_64/kernel/traps.c b/arch/x86_64/kernel/traps.c
--- a/arch/x86_64/kernel/traps.c 2005-03-28 21:22:47 -08:00
+++ b/arch/x86_64/kernel/traps.c 2005-03-28 21:22:47 -08:00
@@ -617,15 +617,6 @@
mem_parity_error(reason, regs);
if (reason & 0x40)
io_check_error(reason, regs);
-
- /*
- * Reassert NMI in case it became active meanwhile
- * as it's edge-triggered.
- */
- outb(0x8f, 0x70);
- inb(0x71); /* dummy */
- outb(0x0f, 0x70);
- inb(0x71); /* dummy */
}
asmlinkage void do_int3(struct pt_regs * regs, long error_code)
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
