ChangeSet 1.2231.1.227, 2005/03/28 20:19:26-08:00, [EMAIL PROTECTED]

        [PATCH] dvb: saa7146: remove duplicate setgpio
        
        Remove duplicate setgpio (Kenneth Aafloy)
        
        Signed-off-by: Johannes Stezenbach <[EMAIL PROTECTED]>
        Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
        Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>



 saa7146_core.c |   29 +++++------------------------
 1 files changed, 5 insertions(+), 24 deletions(-)


diff -Nru a/drivers/media/common/saa7146_core.c 
b/drivers/media/common/saa7146_core.c
--- a/drivers/media/common/saa7146_core.c       2005-03-28 21:58:50 -08:00
+++ b/drivers/media/common/saa7146_core.c       2005-03-28 21:58:50 -08:00
@@ -46,21 +46,15 @@
  * gpio and debi helper functions
  ****************************************************************************/
 
-/* write "data" to the gpio-pin "pin" -- unused */
-void saa7146_set_gpio(struct saa7146_dev *dev, u8 pin, u8 data)
+void saa7146_setgpio(struct saa7146_dev *dev, int port, u32 data)
 {
        u32 value = 0;
 
-       /* sanity check */
-       if(pin > 3)
-               return;
-
-       /* read old register contents */
-       value = saa7146_read(dev, GPIO_CTRL );
-
-       value &= ~(0xff << (8*pin));
-       value |= (data << (8*pin));
+       BUG_ON(port > 3);
 
+       value = saa7146_read(dev, GPIO_CTRL);
+       value &= ~(0xff << (8*port));
+       value |= (data << (8*port));
        saa7146_write(dev, GPIO_CTRL, value);
 }
 
@@ -233,19 +227,6 @@
        }
 */
        return 0;
-}
-
-/********************************************************************************/
-/* gpio functions */
-
-void saa7146_setgpio(struct saa7146_dev *dev, int port, u32 data)
-{
-       u32 val = 0;
-
-        val=saa7146_read(dev,GPIO_CTRL);
-        val&=~(0xff << (8*(port)));
-        val|=(data)<<(8*(port));
-        saa7146_write(dev, GPIO_CTRL, val);
 }
 
 
/********************************************************************************/
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to