tree b5eb725f61202e9a238c538972f1d89387b40d22
parent 2cb9a8c00734a55d1a0291f4cec6f856ed22b6af
author [EMAIL PROTECTED] <[EMAIL PROTECTED]> Tue Apr 12 08:24:32 2005
committer Linus Torvalds <[EMAIL PROTECTED]> Tue Apr 12 08:24:32 2005
[PATCH] arm: add comment about dma_supported()
)
From: Russell King <[EMAIL PROTECTED]>
The ARM dma_supported() is rather basic, and I don't think it takes into
account everything that it should do (eg, whether the mask agrees with what
we'd return for GFP_DMA allocations). Note this.
Signed-off-by: Russell King <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
dma-mapping.h | 3 +++
1 files changed, 3 insertions(+)
Index: include/asm-arm/dma-mapping.h
===================================================================
--- f567341c4142edf5a743f8a8250574cc2e99dd9d/include/asm-arm/dma-mapping.h
(mode:100644 sha1:15340fe6a22a4e155de798d9b2e5eba12ce7405b)
+++ b5eb725f61202e9a238c538972f1d89387b40d22/include/asm-arm/dma-mapping.h
(mode:100644 sha1:334005ab15776f991a6a03adcb8c5a6ceac3228e)
@@ -21,6 +21,9 @@
* properly. For example, if your device can only drive the low 24-bits
* during bus mastering, then you would pass 0x00ffffff as the mask
* to this function.
+ *
+ * FIXME: This should really be a platform specific issue - we should
+ * return false if GFP_DMA allocations may not satisfy the supplied 'mask'.
*/
static inline int dma_supported(struct device *dev, u64 mask)
{
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
