tree bdbdab3160cccb7a595034ecc7695a10b59ae038
parent d570c2bad2d66c9eef8efeff2696a8985a89c19d
author Benjamin Herrenschmidt <[EMAIL PROTECTED]> Tue Apr 12 08:25:09 2005
committer Linus Torvalds <[EMAIL PROTECTED]> Tue Apr 12 08:25:09 2005

[PATCH] ppc64: Detect altivec via firmware on unknown CPUs

This patch adds detection of the Altivec capability of the CPU via the
firmware in addition to the cpu table.  This allows newer CPUs that aren't
in the table to still have working altivec support in the kernel.

It also fixes a problem where if a CPU isn't recognized as having altivec
features, and takes an altivec unavailable exception due to userland
issuing altivec instructions, the kernel would happily enable it and
context switch the registers ...  but not all of them (it would basically
forget vrsave).  With this patch, the kernel will refuse to enable altivec
when the feature isn't detected for the CPU (SIGILL).

Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>

 head.S  |    2 ++
 prom.c  |   19 ++++++++++++++++++-
 traps.c |    2 --
 3 files changed, 20 insertions(+), 3 deletions(-)

Index: arch/ppc64/kernel/head.S
===================================================================
--- f00627406b331d332c4e231ff688f444a6068ff4/arch/ppc64/kernel/head.S  
(mode:100644 sha1:4d1e256582b8c40afab2922864ed54075713aeb9)
+++ bdbdab3160cccb7a595034ecc7695a10b59ae038/arch/ppc64/kernel/head.S  
(mode:100644 sha1:d8dfabbdaea4a6451818d092a589827d759764ae)
@@ -922,7 +922,9 @@
 altivec_unavailable_common:
        EXCEPTION_PROLOG_COMMON(0xf20, PACA_EXGEN)
 #ifdef CONFIG_ALTIVEC
+BEGIN_FTR_SECTION
        bne     .load_up_altivec        /* if from user, just load it up */
+END_FTR_SECTION_IFSET(CPU_FTR_ALTIVEC)
 #endif
        bl      .save_nvgprs
        addi    r3,r1,STACK_FRAME_OVERHEAD
Index: arch/ppc64/kernel/prom.c
===================================================================
--- f00627406b331d332c4e231ff688f444a6068ff4/arch/ppc64/kernel/prom.c  
(mode:100644 sha1:6b0a7bcc17b1cffc0f722b4fbcd5217ff1078692)
+++ bdbdab3160cccb7a595034ecc7695a10b59ae038/arch/ppc64/kernel/prom.c  
(mode:100644 sha1:5f449b4f00b1fe8cc28c9e0c88c04c5df38f6431)
@@ -885,6 +885,7 @@
                                          const char *full_path, void *data)
 {
        char *type = get_flat_dt_prop(node, "device_type", NULL);
+       u32 *prop;
 
        /* We are scanning "cpu" nodes only */
        if (type == NULL || strcmp(type, "cpu") != 0)
@@ -916,6 +917,20 @@
                }
        }
 
+       /* Check if we have a VMX and eventually update CPU features */
+       prop = (u32 *)get_flat_dt_prop(node, "ibm,vmx", NULL);
+       if (prop && (*prop) > 0) {
+               cur_cpu_spec->cpu_features |= CPU_FTR_ALTIVEC;
+               cur_cpu_spec->cpu_user_features |= PPC_FEATURE_HAS_ALTIVEC;
+       }
+
+       /* Same goes for Apple's "altivec" property */
+       prop = (u32 *)get_flat_dt_prop(node, "altivec", NULL);
+       if (prop) {
+               cur_cpu_spec->cpu_features |= CPU_FTR_ALTIVEC;
+               cur_cpu_spec->cpu_user_features |= PPC_FEATURE_HAS_ALTIVEC;
+       }
+
        return 0;
 }
 
@@ -1104,7 +1119,9 @@
 
        DBG("Scanning CPUs ...\n");
 
-       /* Retreive hash table size from flattened tree */
+       /* Retreive hash table size from flattened tree plus other
+        * CPU related informations (altivec support, boot CPU ID, ...)
+        */
        scan_flat_dt(early_init_dt_scan_cpus, NULL);
 
        /* If hash size wasn't obtained above, we calculate it now based on
Index: arch/ppc64/kernel/traps.c
===================================================================
--- f00627406b331d332c4e231ff688f444a6068ff4/arch/ppc64/kernel/traps.c  
(mode:100644 sha1:11acae56c057c0f8dd5543f520245039ed0f0965)
+++ bdbdab3160cccb7a595034ecc7695a10b59ae038/arch/ppc64/kernel/traps.c  
(mode:100644 sha1:42eb881383a05f9131a6e89e3e933bacc54eff38)
@@ -450,14 +450,12 @@
 
 void altivec_unavailable_exception(struct pt_regs *regs)
 {
-#ifndef CONFIG_ALTIVEC
        if (user_mode(regs)) {
                /* A user program has executed an altivec instruction,
                   but this kernel doesn't support altivec. */
                _exception(SIGILL, regs, ILL_ILLOPC, regs->nip);
                return;
        }
-#endif
        printk(KERN_EMERG "Unrecoverable VMX/Altivec Unavailable Exception "
                          "%lx at %lx\n", regs->trap, regs->nip);
        die("Unrecoverable VMX/Altivec Unavailable Exception", regs, SIGABRT);
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to