tree ef4138c02aa447610146df63749e07c1859c3509
parent 05985715756b8667cb35a3e05e1668bb8afe3298
author Jean Delvare <[EMAIL PROTECTED]> Tue, 19 Apr 2005 11:16:58 -0700
committer Greg KH <[EMAIL PROTECTED]> Tue, 19 Apr 2005 11:16:58 -0700

[PATCH] I2C: via686a cleanups

Here comes a small cleanup patch for the via686a driver. I noticed the
following two non-fatal problems:

1* The device parent is explicitely set, but it's not needed because the
i2c core will do as the client is registered.

2* snprintf is used where strlcpy would suffice.

Fixing them brings the via686a driver in line with what other similar
drivers do.

Signed-off-by: Jean Delvare <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>


 i2c/chips/via686a.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

Index: drivers/i2c/chips/via686a.c
===================================================================
--- d990e8d99830ebb1d60f36a23512b3cd838a8585/drivers/i2c/chips/via686a.c  
(mode:100644 sha1:9b948f4531f5ade8899ca3efee959c7c3d33da04)
+++ ef4138c02aa447610146df63749e07c1859c3509/drivers/i2c/chips/via686a.c  
(mode:100644 sha1:ecd1e1de3f05abd1ec1eec87c248bf2b137067a4)
@@ -651,10 +651,9 @@
        new_client->adapter = adapter;
        new_client->driver = &via686a_driver;
        new_client->flags = 0;
-       new_client->dev.parent = &adapter->dev;
 
        /* Fill in the remaining client fields and put into the global list */
-       snprintf(new_client->name, I2C_NAME_SIZE, client_name);
+       strlcpy(new_client->name, client_name, I2C_NAME_SIZE);
 
        data->valid = 0;
        init_MUTEX(&data->update_lock);
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to