tree 250f46d1d99247f3d7b67d991929ed6aedb7145d
parent 06f81ea8ca09b880cadf101d7e23b500e9c164bc
author <[EMAIL PROTECTED]> Mon, 18 Apr 2005 01:00:23 -0500
committer James Bottomley <[EMAIL PROTECTED]> Mon, 18 Apr 2005 22:35:56 -0500
[PATCH] scsi: scsi_send_eh_cmnd() cleanup
This patch makes scsi_send_eh_cmnd() use sdev and shost instead of
referencing them through scmd-> everytime.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
scsi/scsi_error.c | 25 +++++++++++++------------
1 files changed, 13 insertions(+), 12 deletions(-)
Index: drivers/scsi/scsi_error.c
===================================================================
--- 87e70ac102f2498214f42e8f0ad879513669881b/drivers/scsi/scsi_error.c
(mode:100644 sha1:203a0812508a1962c2c9d58020d3a6a9bc61aaf5)
+++ 250f46d1d99247f3d7b67d991929ed6aedb7145d/drivers/scsi/scsi_error.c
(mode:100644 sha1:1a135f38e78d8965d9a9fab95ca58614e7db61a3)
@@ -476,7 +476,8 @@
**/
static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, int timeout)
{
- struct Scsi_Host *host = scmd->device->host;
+ struct scsi_device *sdev = scmd->device;
+ struct Scsi_Host *shost = sdev->host;
DECLARE_MUTEX_LOCKED(sem);
unsigned long flags;
int rtn = SUCCESS;
@@ -487,27 +488,27 @@
*/
scmd->owner = SCSI_OWNER_LOWLEVEL;
- if (scmd->device->scsi_level <= SCSI_2)
+ if (sdev->scsi_level <= SCSI_2)
scmd->cmnd[1] = (scmd->cmnd[1] & 0x1f) |
- (scmd->device->lun << 5 & 0xe0);
+ (sdev->lun << 5 & 0xe0);
scsi_add_timer(scmd, timeout, scsi_eh_times_out);
/*
* set up the semaphore so we wait for the command to complete.
*/
- scmd->device->host->eh_action = &sem;
+ shost->eh_action = &sem;
scmd->request->rq_status = RQ_SCSI_BUSY;
- spin_lock_irqsave(scmd->device->host->host_lock, flags);
+ spin_lock_irqsave(shost->host_lock, flags);
scsi_log_send(scmd);
- host->hostt->queuecommand(scmd, scsi_eh_done);
- spin_unlock_irqrestore(scmd->device->host->host_lock, flags);
+ shost->hostt->queuecommand(scmd, scsi_eh_done);
+ spin_unlock_irqrestore(shost->host_lock, flags);
down(&sem);
scsi_log_completion(scmd, SUCCESS);
- scmd->device->host->eh_action = NULL;
+ shost->eh_action = NULL;
/*
* see if timeout. if so, tell the host to forget about it.
@@ -527,10 +528,10 @@
* abort a timed out command or not. not sure how
* we should treat them differently anyways.
*/
- spin_lock_irqsave(scmd->device->host->host_lock, flags);
- if (scmd->device->host->hostt->eh_abort_handler)
- scmd->device->host->hostt->eh_abort_handler(scmd);
- spin_unlock_irqrestore(scmd->device->host->host_lock, flags);
+ spin_lock_irqsave(shost->host_lock, flags);
+ if (shost->hostt->eh_abort_handler)
+ shost->hostt->eh_abort_handler(scmd);
+ spin_unlock_irqrestore(shost->host_lock, flags);
scmd->request->rq_status = RQ_SCSI_DONE;
scmd->owner = SCSI_OWNER_ERROR_HANDLER;
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
