tree 7a79aef406aa44dcbe887e69656aef61ed98dd9a
parent 7aa52f5128b06d1df9b2ee65c06d401af27da0a4
author [EMAIL PROTECTED] <[EMAIL PROTECTED]> Sun, 17 Apr 2005 05:23:57 -0700
committer Linus Torvalds <[EMAIL PROTECTED]> Sun, 17 Apr 2005 05:23:57 -0700
[PATCH] arm: add comment about dma_supported()
)
From: Russell King <[EMAIL PROTECTED]>
The ARM dma_supported() is rather basic, and I don't think it takes into
account everything that it should do (eg, whether the mask agrees with what
we'd return for GFP_DMA allocations). Note this.
Signed-off-by: Russell King <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
asm-arm/dma-mapping.h | 3 +++
1 files changed, 3 insertions(+)
Index: include/asm-arm/dma-mapping.h
===================================================================
--- c873dd5e581cc9d8b12e931456a8036a943485ef/include/asm-arm/dma-mapping.h
(mode:100644 sha1:925d016dd4b51ecf21fdc8a28d6f9532472d73de)
+++ 7a79aef406aa44dcbe887e69656aef61ed98dd9a/include/asm-arm/dma-mapping.h
(mode:100644 sha1:d62ade4e4cbb24facf3b95a3774e4ec508ba6001)
@@ -21,6 +21,9 @@
* properly. For example, if your device can only drive the low 24-bits
* during bus mastering, then you would pass 0x00ffffff as the mask
* to this function.
+ *
+ * FIXME: This should really be a platform specific issue - we should
+ * return false if GFP_DMA allocations may not satisfy the supplied 'mask'.
*/
static inline int dma_supported(struct device *dev, u64 mask)
{
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
