tree 3bb61f6e6d4e789c516c7ffb125ac89982d9a10c
parent 94ad84740fb3fe6c2112e60bc71a256c2815479d
author Andi Kleen <[EMAIL PROTECTED]> Sun, 17 Apr 2005 05:25:10 -0700
committer Linus Torvalds <[EMAIL PROTECTED]> Sun, 17 Apr 2005 05:25:10 -0700
[PATCH] x86_64: Remove excessive stack allocation in MCE code with large NR_CPUS
Remove excessive stack allocation in MCE code with large NR_CPUS
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
x86_64/kernel/mce.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletion(-)
Index: arch/x86_64/kernel/mce.c
===================================================================
--- f9725aa273ebbfd40253a90b4d6ae1d5564e7a9f/arch/x86_64/kernel/mce.c
(mode:100644 sha1:6ca066424deed52ce3243d5398329647e86c13e2)
+++ 3bb61f6e6d4e789c516c7ffb125ac89982d9a10c/arch/x86_64/kernel/mce.c
(mode:100644 sha1:3a89d735a4f60f7203d8b0d2e5df2d2685d299fa)
@@ -379,18 +379,23 @@
static ssize_t mce_read(struct file *filp, char __user *ubuf, size_t usize,
loff_t *off)
{
- unsigned long cpu_tsc[NR_CPUS];
+ unsigned long *cpu_tsc;
static DECLARE_MUTEX(mce_read_sem);
unsigned next;
char __user *buf = ubuf;
int i, err;
+ cpu_tsc = kmalloc(NR_CPUS * sizeof(long), GFP_KERNEL);
+ if (!cpu_tsc)
+ return -ENOMEM;
+
down(&mce_read_sem);
next = rcu_dereference(mcelog.next);
/* Only supports full reads right now */
if (*off != 0 || usize < MCE_LOG_LEN*sizeof(struct mce)) {
up(&mce_read_sem);
+ kfree(cpu_tsc);
return -EINVAL;
}
@@ -421,6 +426,7 @@
}
}
up(&mce_read_sem);
+ kfree(cpu_tsc);
return err ? -EFAULT : buf - ubuf;
}
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
