tree b4467b2d08a139961e709cfb41bd1f9280249155
parent efab7739d99eae948971140b2aa3dddf7f72c900
author Arun Sharma <[EMAIL PROTECTED]> Sat, 23 Apr 2005 03:06:47 -0700
committer Tony Luck <[EMAIL PROTECTED]> Sat, 23 Apr 2005 03:06:47 -0700
[IA64] ia32_signal.c: erroneous use of memset/memcpy
Found by Alexander Nyberg, improved by Bjorn Helgaas.
- Fix the incorrect argument to sizeof()
- looks like memcpy() code pass was dervived from code that used
copy_from_user(). But in this case we are doing to kernel space
to kernel space copy, so memcpy is the right routine, but it
doesn't return an error code.
Signed-off-by: Arun Sharma <[EMAIL PROTECTED]>
Signed-off-by: Tony Luck <[EMAIL PROTECTED]>
ia64/ia32/ia32_signal.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
Index: arch/ia64/ia32/ia32_signal.c
===================================================================
--- d0278bb7304946182dd4337fcbceb9fc32fb2901/arch/ia64/ia32/ia32_signal.c
(mode:100644 sha1:19b02adce68cd315d7d44cc13ab7cdc29bb82c83)
+++ b4467b2d08a139961e709cfb41bd1f9280249155/arch/ia64/ia32/ia32_signal.c
(mode:100644 sha1:ebb89be2aa2dba5acbcaf7773414ff7ca51a1b87)
@@ -460,10 +460,9 @@ __ia32_rt_sigsuspend (compat_sigset_t *s
sigset_t oldset, set;
scr->scratch_unat = 0; /* avoid leaking kernel bits to user level */
- memset(&set, 0, sizeof(&set));
+ memset(&set, 0, sizeof(set));
- if (memcpy(&set.sig, &sset->sig, sigsetsize))
- return -EFAULT;
+ memcpy(&set.sig, &sset->sig, sigsetsize);
sigdelsetmask(&set, ~_BLOCKABLE);
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
