tree 5a739fb75f8e14b8c5f2274d8f1efa6fed145b34
parent 184f6eb8c46afc2a4aa6cb7c51ebc423c36d9c9d
author Linus Torvalds <[EMAIL PROTECTED]> Thu, 07 Jul 2005 03:05:50 -0700
committer Linus Torvalds <[EMAIL PROTECTED]> Thu, 07 Jul 2005 03:05:50 -0700
ieee1394: fix broken signed char assumption.
"ack_code" is assigned (and tested against) negative numbers, but was
declared as "char". Which only works if "char" is signed - which it
necessarily isn't.
So make that signedness assumption specific.
drivers/ieee1394/ieee1394_core.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ieee1394/ieee1394_core.h b/drivers/ieee1394/ieee1394_core.h
--- a/drivers/ieee1394/ieee1394_core.h
+++ b/drivers/ieee1394/ieee1394_core.h
@@ -38,8 +38,8 @@ struct hpsb_packet {
/* These are core internal. */
signed char tlabel;
- char ack_code;
- char tcode;
+ signed char ack_code;
+ unsigned char tcode;
unsigned expect_response:1;
unsigned no_waiter:1;
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
