tree 0f0bf8deaeabc2d14fbded203392ec5bf7dc37ad
parent 56d1254917d9f301a8e24155cd3f2236e642cb7d
author Qu Fuping <[EMAIL PROTECTED]> Fri, 15 Jul 2005 20:36:08 -0500
committer Dave Kleikamp <[EMAIL PROTECTED]> Fri, 15 Jul 2005 20:36:08 -0500
JFS: fsync wrong behavior when I/O failure occurs
This is half of a patch that Qu Fuping submitted in April. The first part
was applied to fs/mpage.c in 2.6.12-rc4.
jfs_fsync should return error, but it doesn't wait for the metadata page to
be uptodate, e.g.:
jfs_fsync->jfs_commit_inode->txCommit->diWrite->read_metapage->
__get_metapage->read_cache_page reads a page from disk. Because read is
async, when read_cache_page: err = filler(data, page), filler will not
return error, it just submits I/O request and returns. So, page is not
uptodate. Checking only if(IS_ERROR(mp->page)) is not enough, we should
add "|| !PageUptodate(mp->page)"
Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]>
fs/jfs/jfs_metapage.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c
--- a/fs/jfs/jfs_metapage.c
+++ b/fs/jfs/jfs_metapage.c
@@ -640,7 +640,7 @@ struct metapage *__get_metapage(struct i
} else {
page = read_cache_page(mapping, page_index,
(filler_t *)mapping->a_ops->readpage, NULL);
- if (IS_ERR(page)) {
+ if (IS_ERR(page) || !PageUptodate(mp->page)) {
jfs_err("read_cache_page failed!");
return NULL;
}
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
