xOr wrote on Aug 18 at 04:23 pm:
>
> On Sat, 18 Aug 2001, Joey Morris wrote:
>
> > xOr wrote on Aug 18 at 12:56 am:
> > >
> > > On Fri, 17 Aug 2001, Joey Morris wrote:
> > >
> > > > When using the stacked window cycling in bbkeys-0.8.2 on blackbox-0.61.1, I
> > > > have to hit <ENTER> once I've cycled to the window I want in order to give
> > > > control to that window and kill the cycling menu. It seems to me that simply
> > > > releasing the keys would be enough to give control to the desired window.
> > > > This behavior only occurs with the stacked cycling. For linear cycling, I
> > > > only have to release the keys; hitting <ENTER> is not necessary. Is this a
> > > > feature or a bug? If a feature, what is the rationale behind the requirement
> > > > to hit <ENTER>?
> > >
> > > How it works is.. bbkeys will hold the menu up until <enter> is pressed,
> > > or until all of the modifiers for the key combination are released. If
> > > your key binding for window cycling doesn't have any modifiers in it, then
> > > the menu will stay open until you hit <enter> because otherwise you'd only
> > > be able to switch between 2 windows. so, it's actually a feature :)
> > > anyways, that's the low-down.
> >
> > My key binding for NextWindow is Mod3+Tab and for PrevWindow is
> > Mod3+Shift+Tab. I've assigned Mod3 to the Super_L and Super_R keys, which
> > are what I've assigned the Windows keys on my keyboard. To cycle in reverse,
> > using the PrevWindow binding, I don't need to hit <ENTER>, so bbkeys must be
> > interpreting Shift as a modifier but not Mod3. Is this correct?
>
> Ok, well then the problem was as this, bbkeys did have a ModMask
> associated with the XK_Super_[LR] keys. Nor did it have keys associated
> with the Mod3Mask, so I've associated the XK_Super_[LR] keys to the
> Mod3Mask, so your configuration should work fine. Below is a patch
> which will make your configuration work.
>
> xOr
> - --
> you have no chance to survive make your time
>
> - --- bbkeys.cc 2001/08/10 18:51:47 1.48
> +++ bbkeys.cc 2001/08/18 21:21:57
> @@ -1281,6 +1281,10 @@
> case XK_Num_Lock:
> return Mod2Mask;
>
> + case XK_Super_L:
> + case XK_Super_R:
> + return Mod3Mask;
> +
> case XK_Meta_L:
> case XK_Meta_R:
> return Mod4Mask;
Thanks, that fixed the problem. But I'm curious: if someone were to map
their modifiers to their keys in a way different from what is in
ToolWindow::KeycodeToModmask (the function modified by the above patch),
would that break things?
Joey
