* [01/06/02 21:23] Of all the gin joints in all the towns in all the world,
* Sean 'Shaleh' Perry <[EMAIL PROTECTED]> walks into mine and says:
>
> On 07-Jan-2002 Jason 'vanRijn' Kasper wrote:
> > Hm thrice. The problem here is that blackbox is trying to perform a
> > maximize operation on a window that's not visible. I believe that the
> > correct fix is to add a simple check to the top of
> > BlackboxWindow::maximize to see whether the window we're performing this
> > operation on is even visible.
> >
> > It's a one-liner fix, so I don't think a patch is necessary. But my
> > suggestion is to add "if (!flags.visible) return;" to the top of this
> > function. In the 62.0pre2 source of Window.cc, at line 1485, change
> >
> > void BlackboxWindow::maximize(unsigned int button) {
> >
> > to
> >
> > void BlackboxWindow::maximize(unsigned int button) {
> > if (!flags.visible) return;
> >
> >
> > Any thoughts contrary to this?
> >
>
> Let me get this straight. You have Window A focused. You click the iconify
> button. It goes away to icon land. You then hit alt+m (or whatever you have
> as MaximizeWindow) and blackbox crashes because it tries to maximize the window
> it just iconifed? It sounds to me like the real problem is blackbox is using
> the wrong window as the recipient of messages. Or did I misunderstand?
>
If blackbox doesn't set focus on a window other than the one it just
minimized, than the now-iconified window still is marked as being the
current window. Note--this problem only occurs when blackbox minimizes
a window and doesn't have another window to set focus on. bbkeys isn't
given a different "currently focused" window to operate on, so it tells
blackbox to perform whatever operation (in this case maximize) on the
now-iconified window. It's an obscure bug, but I think blackbox should
be doing a sanity check (especially such a simple one as this).
--
----%<----------%<----
Jason Kasper (vanRijn)
bash$ :(){ :|:&};:
Numbers 6:24-26
