On 16-Jan-2002 Scott Moynes wrote: > I have found a set of annoying aesthetic bugs, as well as a crasher in > the Edit Workspace Name code. > First, the crasher: >
I do see this in the 0.62.x series, it takes a solid minute of typing on my end. > > To reproduce this edit the workspace name and hammer on the keyboard > for a bit. The xset is there just to speed up the process. I've had > several wierd things happen when doing this. Sometimes it SEGVs as it > is shown here. Once, I recall it dumped core in libc. It looked like > it was trying to free bad memory, but I didn't manage to catch > that. The char s[1024] buffer seems a little extreme big, and also is > never checked for buffer overflows. > > The aesthetic bugs are related to the same code. Enter a fairly long > workspace name, say 100 characters or so, and hit enter. The toolbar > gets ruined. Also, one can edit the workspace, switch to another > workspace, and begin typing. This will produce unexpected > results. There are also some minor bugs to do with typing odd > characters while inputting the workspace name. eg: control c. > My guess for both of these is Brad assumed people would Do The Right Thing(tm). By setting the buffer to 1024, he basically could ignore checking the input. The fact that you can switch workspaces while editing is more concerning. Will add this to the todo. While we are cleaning up the various class files we can also clear out bugs like this.
