Observation:
Perusing the blackbox code I see that in
BColor &BColor::operator=(const BColor &c)
there's no coping with the consequences of a self-assignment - it may be
that that's impossible, but if it were then the code in that member
function looks pretty terminal!
The old style to avoid such problems was a
if (*this == rhs) return;
the more modern style is to use std::swap and use the copy constructor
avoiding problems with exceptions
Suggestion:
I have lots of styles (too many!) and I like to cateogise them in
subdirectories, unfortuately the menu parsing ignores subdirectories for
stylesdir. I've tried something like
[submenu] (styles)
[stylesdir] (~/.blackbox/styles/)
[submenu] (plain)
[stylesdir] (~/.blackbox/styles/plain)
[end]
[submenu] (nature)
[stylesdir] (~/.blackbox/styles/nature)
[end]
....
[end]
but that seems too much faffing about and a lot of duplication of something
bb could do itself!
Would a patch be welcome which traversed subdirectories of the stylesdir?
R
--
Robert Marshall
