On Nov 30, 2011, at 5:59 PM, Patrick Robertson wrote: > Looking at the code, I can see that that is indeed the case! > > The fix is very simple. Would you be able to create an issue at > https://github.com/quicksilver/Quicksilver/issues so that we can keep track > of it? > > Note to Devs: > > QSControler.m:623 needs to be changed to: > > if (lastLocation && ![[bundlePath > stringByDeletingLastPathComponent] isEqualToString:[[lastLocation > stringByDeletingLastPathComponent] stringByStandardizingPath]]) { > > * Warning this change might give a merge conflict with my Localisations pull > request.
Using the full path for comparison doesn’t seem so unreasonable to me. By only using the directory, you could end up with multiple copies of Quicksilver (or worst case scenario, it could replace /Applications itself with Quicksilver.app). And maybe the Dock icon and startup item point to the old one and not the one you think it does, etc. Maybe we should just update the warning to include the full path so it’s not as misleading? -- Rob McBroom <http://www.skurfer.com/>
