#1551: JasPer
-----------------------------------------+----------------------------------
Reporter: bdu...@… | Owner: k...@…
Type: enhancement | Status: assigned
Priority: normal | Milestone: 6.4
Component: BOOK | Version: SVN
Severity: minor | Resolution:
Keywords: |
-----------------------------------------+----------------------------------
Changes (by k...@…):
* status: new => assigned
Comment:
Normally, these comments would be better in email, but I don't have your
address. Sorry for filling up the mailboxes of everyone else subscribed to
-book.
As Bruce said, too many different things in one patch makes it hard to
revue. I see you've attached something to the ghostscript and URW fonts
tickets, but they're not mine.
For gsview, I'm not touching it because it is a gtk+-1.2 application.
Specific comments on the JasPer part of the patch:
1. The ftp download cannot be right if it has a different size and md5sum.
2. The md5sum and size (for the http version) don't match mine, I think
you probably forgot to update them from whatever you copied.
3. I don't install the static lib (that's standard for me, as you'll
notice), but I can't agree your buildsize and time. The SBU time I won't
quibble about, I expect it to vary from machine to machine and from build-
host to build-host, but the size suggests you haven't counted the
documentation although you install it. I also think the README file isn't
worth installing (it just says what the two pdf files are), but that is a
matter of choice.
4. In dependencies you don't mention xorg. I also have an optional pair
of switches for people who install it in uncommon prefixes. I also have
differences of style - doesn't seem worth listing exactly what a
dependency provides if everyone is likely to have it anyway.
5. I don't agree that the utility programs are restricted to jpeg2000
images: they all appear to be for bmp, jps, jpc, jpg, pgx, pnm, mif, ras
(according to the pdf) and certainly imginfo [ -f ] and jiv do work on jpg
files.
Other than that, and ignoring changelog entries until the commit is made,
it looks good. I was already working on this, but I see now that trac
thinks I only own it. For the future, an email offering to create a patch
*before* you spend a lot of time on it, will reduce wasted effort.
Setting ticket to accepted.
I'm out of time tonight, updating the package will have to wait.
--
Ticket URL: <http://wiki.linuxfromscratch.org/blfs/ticket/1551#comment:6>
BLFS Trac <http://wiki.linuxfromscratch.org/blfs>
Beyond Linux From Scratch
--
http://linuxfromscratch.org/mailman/listinfo/blfs-book
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
