Re: [blfs-book] r16653 - trunk/BOOK/x/installing

[Bruce Dubbs]

Pierre Labastie wrote:
On 14/11/2015 22:49, Bruce Dubbs wrote:
pie...@higgs.linuxfromscratch.org wrote:
Author: pierre
Date: Sat Nov 14 13:36:59 2015
New Revision: 16653
Log:
Misplaced role="root" in Xorg introduction, and other changes:
- $XORG_PREFIX is not <replaceable>, /usr/X11R6 is.
- Use the already set $XORG_PREFIX in /etc/profile.d/xorg.sh.

Modified:
     trunk/BOOK/x/installing/xorg7.xml

Modified: trunk/BOOK/x/installing/xorg7.xml
==============================================================================
--- trunk/BOOK/x/installing/xorg7.xml    Sat Nov 14 08:50:27 2015    (r16652)
+++ trunk/BOOK/x/installing/xorg7.xml    Sat Nov 14 13:36:59 2015    (r16653)
@@ -123,9 +123,9 @@
       file containing these variables as the
       <systemitem class="username">root</systemitem> user:</para>

-<screen><userinput role="root">cat &gt; /etc/profile.d/xorg.sh &lt;&lt; "EOF"
-XORG_PREFIX="<replaceable>&lt;PREFIX&gt;</replaceable>"
-XORG_CONFIG="--prefix=$XORG_PREFIX --sysconfdir=/etc --localstatedir=/var
--disable-static"
+<screen role="root"><userinput>cat &gt; /etc/profile.d/xorg.sh &lt;&lt; EOF
+XORG_PREFIX="$XORG_PREFIX"
+XORG_CONFIG="--prefix=\$XORG_PREFIX --sysconfdir=/etc --localstatedir=/var
--disable-static"

For XORG_CONFIG, we really don't want \$XORG_PREFIX.  We want:

$ echo $XORG_CONFIG
--prefix=/opt/xorg --sysconfdir=/etc --localstatedir=/var --disable-static

I have no problem with the other changes.

Well, Before my change ,there was "EOF" instead of EOF, and there was no \
before the second $XORG_PREFIX. So the effect is the same : eventually, the
file contains:
XORG_PREFIX="/opt/xorg" (or whatever)
XORG_CONFIG="--prefix=$XORG_PREFIX --sysconfdir=/etc --localstatedir=/var
--disable-static" (sorry for broken line)

The only change is that when copy-pasting, you only need to edit XORG_CONFIG
once (at the beginning), and not in this instruction.

If you want to revert anyway, just tell me.

I guess it's OK either way.  I personally prefer removing the \ from the $ 
and hard coding the value in the profile script, but for the book it's OK 
either way.  No need to revert.

  -- Bruce
--
http://lists.linuxfromscratch.org/listinfo/blfs-book
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page