Re: [blfs-book] r17514 - in trunk/BOOK: introduction/welcome multimedia/cdwriteutils

[Ken Moffat via blfs-book]

On Tue, Jun 21, 2016 at 12:35:09AM -0000, via blfs-book wrote:
> Author: dj
> Date: Mon Jun 20 17:35:09 2016
> New Revision: 17514
> 
> Log:
> Add CXXFLAGS for Cdrdao package to allow building with GCC-6.1.
> 
Two comments -
> Modified:
>    trunk/BOOK/introduction/welcome/changelog.xml
>    trunk/BOOK/multimedia/cdwriteutils/cdrdao.xml
> 
> Modified: trunk/BOOK/introduction/welcome/changelog.xml
> ==============================================================================
> --- trunk/BOOK/introduction/welcome/changelog.xml     Mon Jun 20 02:07:00 
> 2016        (r17513)
> +++ trunk/BOOK/introduction/welcome/changelog.xml     Mon Jun 20 17:35:09 
> 2016        (r17514)
> @@ -54,6 +54,10 @@
>            <para>[igor] - Update to unbound-1.5.9. Fixes
>            <ulink url="&blfs-ticket-root;7938">#7938</ulink>.</para>
>          </listitem>
> +        <listitem>
> +          <para>[dj] - Add CXXFLAGS for Cdrdao package to allow building with
> +          GCC-6.1.</para>
> +        </listitem>
>        </itemizedlist>
>      </listitem>
>  

The current practice is to add new changes at the top, so that the
changes on a particular day read from bottom to top.  I didn't like
it when it was itroduced, and it took me ages to get used to.
> 
> Modified: trunk/BOOK/multimedia/cdwriteutils/cdrdao.xml
> ==============================================================================
> --- trunk/BOOK/multimedia/cdwriteutils/cdrdao.xml     Mon Jun 20 02:07:00 
> 2016        (r17513)
> +++ trunk/BOOK/multimedia/cdwriteutils/cdrdao.xml     Mon Jun 20 17:35:09 
> 2016        (r17514)
> @@ -81,7 +81,8 @@
>  <screen><userinput>sed -i '/ioctl/a #include &lt;sys/stat.h&gt;' 
> dao/ScsiIf-linux.cc    &amp;&amp;
>  sed -i 's/\(char .*REMOTE\)/unsigned \1/' dao/CdrDriver.{cc,h} &amp;&amp;
>  
> -./configure --prefix=/usr --mandir=/usr/share/man &amp;&amp;
> +CXXFLAGS+=' -std=c++11 -Wno-narrowing' \
> +    ./configure --prefix=/usr --mandir=/usr/share/man &amp;&amp;
>  make</userinput></screen>

The second sed (from fedora) fixes the narrowing, and with it
forcing c++11 is unnecessary.  And I tested it before tagging it for
gcc6.  The second sed is documented in the command explanations.

ĸen
-- 
                       War is Peace
                    Freedom is Slavery
                   Ignorance is Strength
-- 
http://lists.linuxfromscratch.org/listinfo/blfs-book
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page