#12355: pango-1.44.3 (holding due to major compatibility problems.
-------------------------+------------------------
 Reporter:  bdubbs       |       Owner:  blfs-book
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  hold
Component:  BOOK         |     Version:  SVN
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------------

Comment (by renodr):

 It looks like we'll need this for nautilus:

 {{{
 [108/249] Compiling C object 'src/25a6634@@nautilus@sta/nautilus-view-
 icon-item-ui.c.o'.
 FAILED: src/25a6634@@nautilus@sta/nautilus-view-icon-item-ui.c.o
 cc -Isrc/25a6634@@nautilus@sta -Isrc -I../src -I. -I../ -Ilibnautilus-
 extension -I../libnautilus-extension -Isubprojects/libgd
 -I../subprojects/libgd -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0
 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/gtk-3.0
 -I/usr/include/gio-unix-2.0 -I/usr/include/pango-1.0
 -I/usr/include/fribidi -I/usr/include/atk-1.0 -I/usr/include/cairo
 -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2
 -I/usr/include/harfbuzz -I/usr/include/libdrm -I/usr/include/libpng16
 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid
 -I/usr/include/gnome-autoar-0 -I/usr/include/gnome-desktop-3.0
 -I/usr/include/gsettings-desktop-schemas -I/usr/include/tracker-2.0
 -I/usr/include/tracker-2.0/libtracker-sparql -I/usr/include/libxml2
 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-
 pch -std=c11 -g -Wall -Wduplicated-branches -Wduplicated-cond -Wlogical-op
 -Werror=declaration-after-statement -Werror=empty-body -Werror=format=2
 -Werror=implicit-function-declaration -Werror=incompatible-pointer-types
 -Werror=init-self -Werror=missing-include-dirs -Werror=missing-prototypes
 -Werror=pointer-arith -Werror=sequence-point -Werror=shadow -Werror
 =strict-prototypes -Werror=undef -Werror=uninitialized -Wno-error=maybe-
 uninitialized -D_GNU_SOURCE -DGLIB_DISABLE_DEPRECATION_WARNINGS -fPIC
 -pthread -DLIBGD_GTK_HACKS=1 -DLIBGD__VIEW_COMMON=1
 -DLIBGD_MAIN_ICON_VIEW=1 -DLIBGD_MAIN_LIST_VIEW=1 -DLIBGD_MAIN_VIEW=1
 -DLIBGD_TAGGED_ENTRY=1 -MD -MQ 'src/25a6634@@nautilus@sta/nautilus-view-
 icon-item-ui.c.o' -MF 'src/25a6634@@nautilus@sta/nautilus-view-icon-item-
 ui.c.o.d' -o 'src/25a6634@@nautilus@sta/nautilus-view-icon-item-ui.c.o' -c
 ../src/nautilus-view-icon-item-ui.c
 ../src/nautilus-view-icon-item-ui.c: In function ‘constructed’:
 ../src/nautilus-view-icon-item-ui.c:154:40: error: implicit declaration of
 function ‘pango_attr_insert_hyphens_new’; did you mean
 ‘pango_attr_gravity_hint_new’? [-Werror=implicit-function-declaration]
   154 |     pango_attr_list_insert (attr_list,
 pango_attr_insert_hyphens_new (FALSE));
       |
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       |                                        pango_attr_gravity_hint_new
 ../src/nautilus-view-icon-item-ui.c:154:40: warning: passing argument 2 of
 ‘pango_attr_list_insert’ makes pointer from integer without a cast [-Wint-
 conversion]
   154 |     pango_attr_list_insert (attr_list,
 pango_attr_insert_hyphens_new (FALSE));
       |
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       |                                        |
       |                                        int
 In file included from /usr/include/pango-1.0/pango/pango.h:25,
                  from /usr/include/gtk-3.0/gdk/gdktypes.h:35,
                  from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:30,
                  from /usr/include/gtk-3.0/gdk/gdk.h:32,
                  from /usr/include/gtk-3.0/gtk/gtk.h:30,
                  from ../src/nautilus-view-icon-item-ui.h:4,
                  from ../src/nautilus-view-icon-item-ui.c:1:
 /usr/include/pango-1.0/pango/pango-attributes.h:535:25: note: expected
 ‘PangoAttribute *’ {aka ‘struct _PangoAttribute *’} but argument is of
 type ‘int’
   535 |         PangoAttribute *attr);
       |         ~~~~~~~~~~~~~~~~^~~~
 cc1: some warnings being treated as errors
 ninja: build stopped: subcommand failed.
 24.9 Elasped Time - nautilus-3.34.2
 }}}

 I think we've got two options here:

 - Manually revert the change in Nautilus: "canvas-item, view-icon-item-ui:
 Don't hyphenate filenames "
 - Take a cairo snapshot and update to Pango-1.44.7 and the new Cairo
 snapshot (assuming it doesn't break PyGTK and other applications)

 I don't know if there will be any consequences of reverting the change. I
 don't want to hold it either because of the DND change that has to do with
 display scaling on Xorg and Wayland (offsets weren't calculated correctly
 in 3.34.1 after the latest GTK+ was released).

--
Ticket URL: <http://wiki.linuxfromscratch.org/blfs/ticket/12355#comment:6>
BLFS Trac <http://wiki.linuxfromscratch.org/blfs>
Beyond Linux From Scratch
-- 
http://lists.linuxfromscratch.org/listinfo/blfs-book
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to