Alexander E. Patrakov wrote:
Hello,

I propose to add a new paragraph/section explaining the kernel setup for ALSA. IMHO it is OK to mention the alternatives: in-kernel and external ALSA drivers.

Yes, I agree to put back alsa-drivers section in it's entirety, with a note mentioning that it's not at all necessary unless you need/want the updated drivers.


Also, please change the volume restoration script a bit:

1) In the udev rule, change RUN= to RUN+=, in order to preserve RUN targets added by other rules.

I agree, but wanted to mention that this was done intentionaly (with my own misunderstanding) to avoid the defs in the 25-lfs.rules. It was not necessary anyway, but hopefully the alsa devices will simply not be included in future versions of that file.

2) Move "sleep 1" to the very bottom in the loop, so that it is not unconditional.

Yes, I had forgotten about that.

3) Use x=$(( $x + 1 )) instead of `expr ${x} + 1` because of /usr/bin/expr and the fact that /bin/sh may be a non-bash.

And another good point. IIRC, it was not compatible with tcsh, but we'll not bother with c shells and all is well with ash, zsh, and bash.

Thanks Alexander.

-- DJ Lucas
--
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to