On Mon, Jan 26, 2009 at 12:16 AM, Alexander E. Patrakov
<[email protected]> wrote:
> Hello,
>
> there is a ticket (http://wiki.linuxfromscratch.org/blfs/ticket/2821)
> that explains why BLFS shouldn't update to a new version of Mut now
> (i.e.: known bug in that release). Since many BLFS users (especially
> after a stable release) completely disregard versions and always use the
> latest ones (and in many other cases that's fine), I propose to mark all
> such cases of broken upstream with more than a Trac ticket.
I was originally going for the upgrade, but, I released what you
meant, that Mutt 1.5.19 has problems when closing a mail tunnel.
> In other words, the explanation why Mutt-1.5.19 is bad should be in the
> book.
I however back ported a fix for Mutt's md5.h header, under some
conditions, it loops infinitely. It is attached here.
> --
> Alexander E. Patrakov
> --
William
diff -Naur mutt-1.5.18-orig/md5.h mutt-1.5.18/md5.h
--- mutt-1.5.18-orig/md5.h 2008-01-29 22:26:50.000000000 -0600
+++ mutt-1.5.18/md5.h 2009-01-26 07:49:31.000000000 -0600
@@ -1,6 +1,7 @@
/* Declaration of functions and data types used for MD5 sum computing
library functions.
- Copyright (C) 1995-1997,1999-2005 Free Software Foundation, Inc.
+ Copyright (C) 1995-1997,1999,2000,2001,2004,2005,2006,2008
+ Free Software Foundation, Inc.
NOTE: The canonical source of this file is maintained with the GNU C
Library. Bugs can be reported to [email protected].
@@ -51,12 +52,6 @@
# endif
#endif
-#ifndef __attribute__
-# if ! __GNUC_PREREQ (2,8) || __STRICT_ANSI__
-# define __attribute__(x)
-# endif
-#endif
-
#ifndef _LIBC
# define __md5_buffer md5_buffer
# define __md5_finish_ctx md5_finish_ctx
@@ -79,7 +74,7 @@
md5_uint32 total[2];
md5_uint32 buflen;
- char buffer[128] __attribute__ ((__aligned__ (__alignof__ (md5_uint32))));
+ md5_uint32 buffer[32];
};
/*
@@ -108,19 +103,13 @@
/* Process the remaining bytes in the buffer and put result from CTX
in first 16 bytes following RESBUF. The result is always in little
endian byte order, so that a byte-wise output yields to the wanted
- ASCII representation of the message digest.
-
- IMPORTANT: On some systems it is required that RESBUF be correctly
- aligned for a 32 bits value. */
+ ASCII representation of the message digest. */
extern void *__md5_finish_ctx (struct md5_ctx *ctx, void *resbuf) __THROW;
/* Put result from CTX in first 16 bytes following RESBUF. The result is
always in little endian byte order, so that a byte-wise output yields
- to the wanted ASCII representation of the message digest.
-
- IMPORTANT: On some systems it is required that RESBUF is correctly
- aligned for a 32 bits value. */
+ to the wanted ASCII representation of the message digest. */
extern void *__md5_read_ctx (const struct md5_ctx *ctx, void *resbuf) __THROW;
--
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
