Re: [blfs-dev] [blfs-book] r9100 - in trunk/BOOK: . general/genlib general/genutils introduction/welcome x/lib

[Andrew Benton]

On Sun, 11 Dec 2011 22:30:24 -0700 (MST)
bdu...@linuxfromscratch.org wrote:

> Author: bdubbs
> Date: 2011-12-11 22:30:20 -0700 (Sun, 11 Dec 2011)
> New Revision: 9100
> 
> Modified:
>    trunk/BOOK/general.ent
>    trunk/BOOK/general/genlib/libglade.xml
>    trunk/BOOK/general/genutils/rep-gtk.xml
>    trunk/BOOK/introduction/welcome/changelog.xml
>    trunk/BOOK/x/lib/cairo.xml
>    trunk/BOOK/x/lib/gtk+2.xml
>    trunk/BOOK/x/lib/hicolor-icon-theme.xml
> Log:
> Updated to rep-gtk-0.90.2.
> 
> Modified: trunk/BOOK/x/lib/gtk+2.xml
> ===================================================================
> --- trunk/BOOK/x/lib/gtk+2.xml        2011-12-12 01:28:51 UTC (rev 9099)
> +++ trunk/BOOK/x/lib/gtk+2.xml        2011-12-12 05:30:20 UTC (rev 9100)
> @@ -93,13 +93,16 @@
>      <para>Install <application>gtk+-2</application> by running
>      the following commands:</para>
>  
> -<screen><userinput>sed -i '/db2html/i@HAVE_DOCBOOK_TRUE@\t   mkdir gtk-tut; 
> \\
> -/gtk-tut html/i@HAVE_DOCBOOK_TRUE@\t   mv *.html gtk-tut; \\' \
> -    docs/tutorial/Makefile.in &amp;&amp;
> -sed -i '/db2html/i@HAVE_DOCBOOK_TRUE@\t   mkdir gtk-faq; \\
> -/gtk-faq html/i@HAVE_DOCBOOK_TRUE@\t   mv *.html gtk-faq; \\' \
> -    docs/faq/Makefile.in &amp;&amp;
> -sed -i 's#^\(      gtk_icon_view_\)l#\1queue_l#' gtk/gtkiconview.c &amp;&amp;
> +<screen><userinput>sed -i -e '/db2html/i@HAVE_DOCBOOK_TRUE@\t   mkdir 
> gtk-tut; '          \
> +       -e '/gtk-tut html/i@HAVE_DOCBOOK_TRUE@\t   mv *.html gtk-tut; ' \
> +    docs/tutorial/Makefile.in                                         
> &amp;&amp;
> +
> +sed -i -e '/db2html/i@HAVE_DOCBOOK_TRUE@\t   mkdir gtk-faq; '          \
> +       -e '/gtk-faq html/i@HAVE_DOCBOOK_TRUE@\t   mv *.html gtk-faq;'  \
> +    docs/faq/Makefile.in                                              
> &amp;&amp;
> +
> +sed -i -e 's#^\(      gtk_icon_view_\)l#\1queue_l#' gtk/gtkiconview.c 
> &amp;&amp;
> +
>  ./configure --prefix=/usr --sysconfdir=/etc &amp;&amp;
>  make</userinput></screen>
>  
> @@ -111,11 +114,12 @@
>  
>      <para>Now, as the <systemitem class="username">root</systemitem> 
> user:</para>
>  
> -<screen role="root"><userinput>make install &amp;&amp;
> -sed -i 's/#man_MANS/man_MANS/' docs/reference/gtk/Makefile &amp;&amp;
> -make -C docs/reference/gtk install-man &amp;&amp;
> -install -v -m755 -d /usr/share/doc/gtk+-&gtk2-version; &amp;&amp;
> -cp -v -R docs/faq/html /usr/share/doc/gtk+-&gtk2-version;/faq &amp;&amp;
> +<screen role="root"><userinput>make install                                  
>                   &amp;&amp;
> +sed -i 's/#man_MANS/man_MANS/' docs/reference/gtk/Makefile      &amp;&amp;
> +make -C docs/reference/gtk install-man                          &amp;&amp;
> +        
> +install -v -m755 -d         /usr/share/doc/gtk+-&gtk2-version;          
> &amp;&amp;
> +cp -v -R docs/faq/html      /usr/share/doc/gtk+-&gtk2-version;/faq      
> &amp;&amp;
>  cp -v -R docs/tutorial/html /usr/share/doc/gtk+-&gtk2-version;/tutorial 
> &amp;&amp;
>  install -v -m644 docs/*.txt 
> /usr/share/doc/gtk+-&gtk2-version;</userinput></screen>

There doesn't seem to be any technical reason to make these changes.
Don't you think it would have been polite to discuss this before you
committed the changes?

Andy
-- 
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page