On 07/20/2014 07:50 PM, Bruce Dubbs wrote: > Armin K. wrote: >> On 07/20/2014 06:47 PM, Bruce Dubbs wrote: >>> [email protected] wrote: >>>> Author: krejzi >>>> Date: Sun Jul 20 08:55:27 2014 >>>> New Revision: 13509 >>>> >>>> Log: >>>> Convert iptables, firewall section and haveged to systemd. >>>> Remove network service files from systemd-units. >>>> >>>> Added: >>>> branches/systemd/systemd-units/blfs/units/haveged.service >>>> branches/systemd/systemd-units/blfs/units/iptables.service >>> >>> Just a question. Since the .service files are so short, wouldn't it be >>> easier to just put them in the respective files as 'here' documents? >> >> Yes, it would. But this makes the change way smaller. Note that makefile >> also runs systemctl and systemd-tmpfiles when necessary. > > Understand. You might want to consider making the change at some point > in the future. My personal preference is to make things obvious when > practical. That is one reason we often use sed instructions instead of > patches. > > -- Bruce >
I would, but I have to manually merge the changes using diff and patch utilits and it's easier to examine a smaller diff than a bigger one. -- Note: My last name is not Krejzi.
signature.asc
Description: OpenPGP digital signature
-- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
