On Fri, Dec 26, 2014 at 11:49:06AM -0300, Fernando de Oliveira wrote:
> Sorry, sent to wrong list.
> 
> On 26-12-2014 11:34, [email protected] wrote:
> > Author: fernando
> > Date: Fri Dec 26 06:34:21 2014
> > New Revision: 15262
> > 
> > Log:
> > Include uninstall option to wicd (bootscripts).
> > 
> > Modified:
> >    trunk/BOOK/general.ent
> >    trunk/bootscripts/ChangeLog
> >    trunk/bootscripts/Makefile
> > 
> > Modified: trunk/BOOK/general.ent
> > ==============================================================================
> > --- trunk/BOOK/general.ent  Thu Dec 25 06:27:10 2014        (r15261)
> > +++ trunk/BOOK/general.ent  Fri Dec 26 06:34:21 2014        (r15262)
> 
> >  <!ENTITY lfs-vim-version              "7.4">
> >  <!-- End LFS versions -->
> >  
> > -<!ENTITY blfs-bootscripts-version     "20141112">
> > +<!ENTITY blfs-bootscripts-version     "20141226">
> >  <!ENTITY blfs-bootscripts-download    
> > "&downloads-root;/blfs-bootscripts-&blfs-bootscripts-version;.tar.bz2">
> 
> > 
> > Modified: trunk/bootscripts/ChangeLog
> > ==============================================================================
> > --- trunk/bootscripts/ChangeLog     Thu Dec 25 06:27:10 2014        (r15261)
> > +++ trunk/bootscripts/ChangeLog     Fri Dec 26 06:34:21 2014        (r15262)
> > @@ -1,3 +1,6 @@
> > +2014-09-01 Fernando de Oliveira <[email protected]>
> > +   * Include uninstall option to wicd
> > +
> >  2014-11-12 Bruce Dubbs <[email protected]>
> >     * Ensure blfs/sysconfig/bluetooth is installed
> >  
> > 
> > Modified: trunk/bootscripts/Makefile
> > ==============================================================================
> > --- trunk/bootscripts/Makefile      Thu Dec 25 06:27:10 2014        (r15261)
> > +++ trunk/bootscripts/Makefile      Fri Dec 26 06:34:21 2014        (r15262)
> .
> 
> > @@ -663,6 +663,16 @@
> >     rm -f ${EXTDIR}/rc.d/rc5.d/S29dbus
> >     rm -f ${EXTDIR}/rc.d/rc6.d/K30dbus
> >  
> > +uninstall-wicd:
> > +   rm -f ${EXTDIR}/rc.d/init.d/wicd
> > +   rm -f ${EXTDIR}/rc.d/rc0.d/K20wicd
> > +   rm -f ${EXTDIR}/rc.d/rc1.d/K20wicd
> > +   rm -f ${EXTDIR}/rc.d/rc2.d/S30wicd
> > +   rm -f ${EXTDIR}/rc.d/rc3.d/S30wicd
> > +   rm -f ${EXTDIR}/rc.d/rc4.d/S30wicd
> > +   rm -f ${EXTDIR}/rc.d/rc5.d/S30wicd
> > +   rm -f ${EXTDIR}/rc.d/rc6.d/K20wicd
> > +
> >  uninstall-dhcpd:
> 
> 
> > @@ -1020,6 +1030,7 @@
> 
> >     install-saslauthd \
> > +   install-wicd \
> >     install-dhcpd \
> 
> > @@ -1064,6 +1075,7 @@
> 
> 
> >     uninstall-saslauthd \
> > +   uninstall-wicd \
> >     uninstall-dhcpd \
> 
> Bruce or somebody else, please verify if I didn't commit any mistake.
> The last time, there was a problem: users could not find the
> bootscripts, or the one I added, can't recall exactly.
> 
 Bootscripts are always a pain - AFAIK, there is no way to generate
the new dated tarball "by hand" : it gets generated when the book
is rendered iff there is a new version in general.ent.  You have
done that and added the uninstall target.

 The last two hunks surprised me, particularly the addition of
install-wicd, but I see these are additions to the .PHONY items -
I'm sure I've probably missed some of those in the past.

 Looks good to me.

ĸen
-- 
Nanny Ogg usually went to bed early. After all, she was an old lady.
Sometimes she went to bed as early as 6 a.m.
-- 
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to