On Thu, May 21, 2015 at 06:10:02PM -0500, Bruce Dubbs wrote: > Douglas R. Reno wrote: > >Hi all, > > > >I need to have someone else's opinion about how to add the patch into > >the instructions. Since it needs configure.ac, autoreconf -fiv must be > >run to regenerate configure, eliminating the changes made by the > >glibc-2.21 patch. Therefore, I need to know how to reorganize the page > >to accommodate the patch. I would like some kind of recommendation on > >how to restructure the page. > > The real fix would be to patch configure.ac for the glibc-2.21 correction > and then run autoreconf. Since the linux_4.x_compilation_fix works on > configure.ac, the glibc fixes could also be merged into a consolidated > patch. > Agreed. Sometimes, we have taken an upstream configure.ac patch, applied it, run autoreconf, and then created a new patch, edited down to just configure. In this case, the opposite approach is required. > Do you need help doing that? > > Also in the patches, do NOT use embedded tabs (in patches or anything else > in BLFS). The valgrind-3.10.1-linux_4.x_compilation_fix-1.patch needs to be > redone to remove them. > > $ cat /etc/vimrc > " Begin /root/.vimrc > > set nocompatible > set backspace=2 > syntax on > > set expandtab > set tabstop=3 > set shiftwidth=3 > set laststatus=2 > ... > > > If an existing file already has tabs in it, the command in vim is :retab > assuming the above vimrc. > > > -- Bruce > Bruce, I can see that you use tiny tab spacing in your own code, but what is your objection to tabs in a patch ? If upstream uses tabs, then tabs are the right thing for the patch. For a sed, spacing and alignment are optional.
ĸen -- Nanny Ogg usually went to bed early. After all, she was an old lady. Sometimes she went to bed as early as 6 a.m. -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
