Arch have updated gst-plugins-bad-1.4.5 to fix a crash with firefox
on youtube. The upstream commit is
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?h=1.4&id=bde0f119097117cf0256e450af426
7a47782260b
What that does is update configure.ac, as you would expect. So, we
could do that, followed by autoreconf -fi, but that is quite noisy
and anyway only two lines are affected. I know you all prefer seds
to patches, so my first working version was:
sed -i -e 's/GST_CHECK_FAAD_VERSION \(FAAD2\)/\1/' \
-e 's/EGREP \"GST_CHECK_FAAD_VERSION \\"2\\.$minor\\"\"/EGREP
\"\\"2\\.$minor\\"$\"/' \
And that gets reformatted by my mailer, as expected - one space
after each EGREP. I'm sure the EGREPs can be removed, but it is
still messy and long (all the escapes) so I've produced a patch:
not yet Submitted By: Ken Moffat <ken at linuxfromscratch dot org>
Date: 2015-06-26
Initial Package Version: 1.4.5
Upstream Status: Applied (to configure.ac)
Origin: Upstream
Description: Fixes miscompilation of the FAAD part of the bad plugins,
that leads to a segfault when firefox tries to play youtube videos.
--- gst-plugins-bad-1.4.5/configure.orig 2015-06-26 18:19:28.496568252
+0100
+++ gst-plugins-bad-1.4.5/configure 2015-06-26 18:23:23.474961187 +0100
@@ -40441,11 +40441,11 @@
/* end confdefs.h. */
#include <$faad_hdr>
- GST_CHECK_FAAD_VERSION FAAD2_VERSION
+ FAAD2_VERSION
_ACEOF
if (eval "$ac_cpp conftest.$ac_ext") 2>&5 |
- $EGREP "GST_CHECK_FAAD_VERSION \"2\.$minor\"" >/dev/null 2>&1; then :
+ $EGREP "\"2\.$minor\"$" >/dev/null 2>&1; then :
faad2_minor_version=$minor
My preference in this case is to use the patch because I think it is
easier to understand.
My firefox, on this week's newest system, can now play youtube
without crashing.
The patch also applies to 0.10.23 (I use that with qupzilla, because
qt4 appears to be stuck with the 0.10 series), although it has an
offset of about -6200 lines - I find such large offsets worrying, so
I rediffed. Again, it stops the browser crashing when a youtube
video starts.
It might take me a little while to get to this - I'm currently
trying to make sense of my *many* notes related to the perl module
dependencies of biber. By building enough to get all the testsuites
to run I'm building 70+ modules, and there are some fixups needed
for 5.20.2 which are ok in 5.22.0. Biber has a couple of failures,
which will be explained on its page, and Net::SSLeay is also now
failing for me, the rest pass. But getting the perl modules page up
to date looks as if it might take as long as the multiple builds and
tests :-(
ĸen
--
Nanny Ogg usually went to bed early. After all, she was an old lady.
Sometimes she went to bed as early as 6 a.m.
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
