I am working on chromium and have a few issues I'd like to discuss.

First of all, this is a huge build.  These are my stats:

SBU=109.765 at -j4; 10208.2 Elapsed Time (2.8 hours);
BUILD SIZE (5252.402 MB)

Right now I have three separate patches and two seds required:

patch -Np1 -i $DIR/chromium-62.0.3202.75-crc32-1.patch        &&
patch -Np1 -i $DIR/chromium-62.0.3202.75-glibc-2.26-1.patch   &&
patch -Np1 -i $DIR/chromium-62.0.3202.75-gn_bootstrap-1.patch &&

# Split this sed so the line is not so long here
string='#define WIDEVINE_CDM_VERSION_STRING "Pinkie Pie"' &&

sed -e "/WIDEVINE_CDM_AVAILABLE/a$string" \
    -i third_party/widevine/cdm/stub/widevine_cdm_version.h &&

sed -e '/frame_buttons.h/a#include "nav_button_layout_manager.h"' \
    -e '/class NavButtonLayoutManager/d' \
    -i chrome/browser/ui/libgtkui/gtk_ui.h &&

The first I have is whether if is appropriate to put these patches into the book as is, or to make a consolidated patch? Of course the seds can be combined into a consolidated patch also. The downside is that some visibility of the changes would be lost. There would be some mitigation by adding appropriate comments to the patch file.

The second issue is that I've found a recommendation for Liberation Fonts. We do refer to them in the TTF-and-OTF-fonts, but leave it up to the user to figure out the install procedure. It's not hard. Just get the tarball, expand and cd, mkdir /usr/share/fonts/truetype/liberation, cp *.ttf /usr/share/fonts/truetype/liberation; fc-cache.

Do we need to be specific about this?

Third issue is minor: add certificates as an optional run time dependency.

Fourth issue is that the display of some lines of text are ragged. Moving the scroll bar or even just clicking in the window will clear up the lines, but sometimes cause other lines to become ragged/unreadable. Repeating generally clears things up. I do not know how to address this, if at all. My support libraries are the latest in BLFS. Another point that may be relevant is that I am running the app over ssh. That may cause some of the problem.

Fifth issue is that I get errors in the launching terminal like:

[7783:7915:1113/101018.241772:ERROR:object_proxy.cc(574)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files

I do not have upower installed and we do not mention it in the dependencies. I'm not sure if we need to address this or not. I think it is partially due to running over ssh, but upower could be added as an optional dependency.

Thoughts?

  -- Bruce
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to