On 11/13/2017 06:44 PM, Armin K. wrote:
On 13.11.2017 18:01, Tim Tassonis wrote:
Hi all

I just recently upgraded to pango 1.40.13 and then encountered some weird new behaviour in the text display on my desktop and file manager.

I'm using an xfce4 based desktop:

- desktop icons with long titles started to overlap
- icon view in thunar really messed up, as it suddenly based the number of horizontal icons to the longest filename. The result was then often one icon instead of four.

A revert to 1.40.12 fixed that. Has anybody else experienced this problem?

Cheers
Tim

I didn't notice it personally, but it looks like it was caused by this commit:

https://git.gnome.org/browse/pango/commit/?id=c4619480e536e393e2d4a8e26a6ceb5af1fe80e3

Reverting it fixes the issue, according to archlinux (or reverting to previous version, as you stated).

Thanks a lot! I read a bit further from your link and there is already a patch for 1.40.13 that fixes the issue, mentioned in:


https://bugzilla.gnome.org/show_bug.cgi?id=789625


It is downloadable from:

https://bugzilla.gnome.org/attachment.cgi?id=362717&action=diff



I attach it to this mail, it applies cleanly (patch p1, as usual) to pango 1.40.13 and fixes my display issues on thunar xfdesktop4.


Kind regards
Tim



--
decentral.ch - IT Stuff
Tim Tassonis
Hohlstrasse 400
c/o Baubüro Insitu
8048 Zürich

[email protected]
+41 79 229 36 17
@@ -, +, @@ 
 pango/break.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
--- a/pango/break.c	
+++ a/pango/break.c	
@@ -1159,11 +1159,10 @@ pango_default_break (const gchar   *text,
 	    }
 
 	  attrs[i].is_line_break = TRUE; /* Rule LB31 */
-	  /* Unicode doesn't specify char wrap; we wrap around all chars
-	   * except where a line break is prohibited, which means we
-	   * effectively break everywhere except inside runs of spaces.
-	   */
-	  attrs[i].is_char_break = TRUE;
+	  /* Unicode doesn't specify char wrap;
+	     we wrap around all chars currently. */
+	  if (attrs[i].is_cursor_position)
+	    attrs[i].is_char_break = TRUE;
 
 	  /* Make any necessary replacements first */
 	  if (row_break_type == G_UNICODE_BREAK_UNKNOWN)
@@ -1458,7 +1457,6 @@ pango_default_break (const gchar   *text,
 	    {
 	    case BREAK_PROHIBITED:
 	      /* can't break here */
-	      attrs[i].is_char_break = FALSE;
 	      attrs[i].is_line_break = FALSE;
 	      break;
 
-- 
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to