On 12/2/2018 12:33 PM, Bruce Dubbs via blfs-dev wrote:
I really don't like this script. I propose adding this note:
"Using the bash completion script below is controversial. Not all
users like it. It adds many (usually over 1000) lines to the bash
environment and makes it difficult to use the 'set' command to examine
simple environment variables. Omitting this script does not interfere
with the ability of bash to use the tab key for file name completion."
Improperly pointed for our default additions of exactly zero lines, but
it does portray my sentiment for the bash-completions package exactly.
:-) It happened to be nice last night, but overall, it's a no for me as
well. The whole point of the script is to provide one that is compatible
if the user wants them, but bypass the ones in
/usr/share/bash-completion/completions if the bash-completions package
is *not* installed and only use the ones in /etc/bash_completions.d if
that's the case. As of February, on a fairly complete system, that was
cargo, dbus, and grub (and grub was moved out of the path yesterday).
cargo and dbus are fairly minimal, but I think we should probably
address their default location as well and let the user decide if they
want the package. Both will wind up in the correct directory if the
bash-completion package is installed at build time, but go to
/etc/bash_completions.d if not. After moving those, I am left with only
one completion, one that I authored and placed there deliberately. I
would suggest leaving the script so that the functionality is available
for the few who want it, fix the installation of cargo and dbus, and
place that note with s/script/package/ with the wiki link.
--DJ
FYI, the remaining completion script (that I added) is a whopping 5
lines including the function definition and closing brace:
_svn-unstash() {
local cur=${COMP_WORDS[COMP_CWORD]}
local list=$(svn-stash-list | awk '{print $1}')
COMPREPLY=( $(compgen -W "$list" -- $cur) )
}
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
