On 02/10/2019 10:59 AM, Pierre Labastie via blfs-dev wrote:
On 10/02/2019 16:49, Bruce Dubbs via blfs-dev wrote:
On 02/10/2019 06:49 AM, Pierre Labastie via blfs-dev wrote:
When updating to 18.12.2 version, the patches for gwenview and libkexiv2 have
been removed. But:
- diffing libkexiv2-18.12.0 and libkexiv2-18.12.2, there is no difference (I
haven't tried diffing gwenview).
- diffing extra-cmake-modules-5.53 and 5.55, there is nothing related to Exiv2
- trying to build libkexiv2 failed during cmake
- trying to build gwenview failed during make, at ~ 17%.
Using the patches for 18.12.0 (they apply cleanly) allow both builds to pass.
Shouldn't we reinstate the patches?
I'm building a fresh 8.4-pre system. When I tested on an 8.3 system, the
patches were not needed. I'll check it out tomorrow when I get to kf5.
Note that the patches are only commented out in the book's source, so it will
be easy to reinstate them if needed.
Not sure it has to do with the LFS version. But it definitely has to do with
Exiv2 version. Version 0.23 to 0.26 should be fine without patch. Only 0.27
needs the patch. According to upstream, 0.26 should still be fine with the
patch, but not the earlier versions (not tried).
I'll upload the patches to the repo (one of the patches needs a small
correction in comments).
I'll wait until you confirm they are needed to reinstate them in the book.
Double checking, you are right. I only has 0.26 in /usr/lib. I had
built 0.27 but put it in a DESTDIR and never updated it in /usr.
-- Bruce
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
