On 6/28/19 7:01 PM, Douglas R. Reno via blfs-dev wrote:
On 6/28/19 11:26 AM, Ken Moffat via blfs-dev wrote:
On Fri, Jun 28, 2019 at 05:54:07PM +0200, Tim Tassonis via blfs-dev
wrote:
Hi all
I have created a patch according to issue #12208 and also added and
commited
it to:
svn+ssh://svn.linuxfromscratch.org/patches/trunk/curl/curl-7.65.1-fix-dns-segfaults-1.patch
I'm not quite sure how to proceed now. It is not (yet) at
http://www.linuxfromscratch.org/patches/blfs/svn/
so modifying the curl page to add the patch there seems not (yet) a good
idea.
Does anyone want to take over from here or point my to a doc how to
go on
myself?
Bye
Tim
Hi Tim:
1. Upload the patch to lfs-patches (done).
2. Change the book and commit it.
3. Wait for the book to be rendered on higgs - at that point I think
the symlinks from the svn book get made.
So, do the edit. The only problems are when we typo the name (memo
to self: patch name in both the Additional Download and the command
to apply it need to match what was uploaded).
And whenever someone says "ooh, you added a patch but the link
doesn't work", recheck the name and then tell them to look at
lfs-patches (or else correct the name).
Summary: when you add a new patch, the link from your local copy
will never work until some time (usually hours) after you committed
the edit.
ĸen
Another thing to remember about patches is our header style. The patch
that we have from Tim doesn't have this:
Submitted By:
Date:
Initial Package Version:
Upstream Status:
Origin:
URL:
Description >
I'm in the process of revamping a couple parts of the patch right now,
mostly having to do with the lib/multi.c portion (it seems to be
completely recreating the file, which shouldn't happen - that's not
Tim's fault though, I think it's something with the patchset that was in
the ticket). I'm going to give him credit as the creator of the patch in
the header, and then add an "Updates" section for the work I'm doing.
Yes, I noticed that the patch creates a .orig file, which I found a bit
strange, too. However, I took the pathches as-is from archlinux and
applied it to a clean tree in the exact order as archlinux does.
I assume that Daniel will release a fixed version of curl soon anyway,
so that patch will go away soon. But since I actually hit that bug on
one machine, I was keen to get the fix in asap.
Thanks for creating the patch, Tim! :-)
P.S. - -1 of the patch is here:
http://linuxfromscratch.org/patches/downloads/curl/curl-7.65.1-fix-dns-segfaults-1.patch
- that gets updated as soon as you commit. It's the SVN folder that
doesn't get updated until the next book render :-)
Thanks a lot. I just updated the curl page to include patch now. It
points to:
http://www.linuxfromscratch.org/patches/blfs/svn/curl-7.65.1-fix-dns-segfaults-1.patch
Hope that is correct.
Bye
Tim
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
