On Sun, Aug 04, 2019 at 03:22:00PM -0500, Douglas R. Reno via blfs-dev wrote:
>
> On 8/4/19 1:18 PM, Bruce Dubbs via blfs-dev wrote:
> >
> > I see three options for this problem, none of which are optimal.
> >
> > 1. Continue to use the sed hack we have been using.
> > Advantage: Simple sed.
> > Disadvantages: Introduces a 'magic' number.
> > Requires finding and changing all affected source
> > files.
> >
> > 2. Use a different sed to add asm-generic/sockios.h as an include in
> > the affected files.
> > Advantage: A more conventional change.
> > Disadvantages: The sed would have to be customized for placement
> > in each affected file.
> > Requires finding and changing all affected source
> > files.
> >
> > 3. Modify bits/socket.h to include asm-generic/sockios.h in LFS.
> > Advantages: Only requires a change in one place.
> > Simple.
> > Disadvantage: Requires modification of a glibc header which we
> > have never done. Additionally asm-generic/sockios.h
> > is a kernel file, but bits/socket.h is a glibc file.
> >
> > My current opinion is option 3 because it is the least intrusive change
> > overall, but I am looking for feedback.
> >
> > -- Bruce
> >
> >
> My opinion is to go with Option 3 because it's what is being done in
> upstream glibc:
>
> https://sourceware.org/git/?p=glibc.git;a=commit;h=c1d1e0c9f242f03521ef023a0e2cac071b5f0133
>
> See the fw/linux-5.2 repo for more details on that
>
On that basis, I agree - it's just a shame this didn't apparently
get into 2.30.
ĸen
--
One pill makes you larger, And one pill makes you small.
And the ones that mother gives you, Don't do anything at all.
Go ask Alice, When she's ten feet tall.
-- Jefferson Airplane, White Rabbit
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
