On Sun, Aug 09, 2020 at 10:57:08AM -0500, Marty Jack via blfs-dev wrote:
>
> I am finding that qtwebengine won't build -- I didn't confirm but it seems
> due to something changed in the latest bison.
> This being a big build if you confirm this I will save you the diagnosis time.
>
> The crux of it is that the code is expecting the bison generated header file
> to be .h and the parse table is expecting it to be .hh.
> The script rule_bison.py takes the .hh file, adds include guards to it, and
> writes it back as .h.
> Then it deletes the .hh file. The following change skips the delete so that
> both the .h and .hh are present and both are happy.
> The .hh that the parse table is using doesn't have include guards but so be
> it, that is how it came out of bison.
>
> diff -Naur
> qtwebengine-5.15.0.orig/src/3rdparty/chromium/third_party/blink/renderer/build/scripts/rule_bison.py
>
> qtwebengine-5.15.0/src/3rdparty/chromium/third_party/blink/renderer/build/scripts/rule_bison.py
> ---
> qtwebengine-5.15.0.orig/src/3rdparty/chromium/third_party/blink/renderer/build/scripts/rule_bison.py
> 2020-05-06 10:21:29.000000000 -0400
> +++
> qtwebengine-5.15.0/src/3rdparty/chromium/third_party/blink/renderer/build/scripts/rule_bison.py
> 2020-08-07 11:43:46.605664714 -0400
> @@ -101,7 +101,6 @@
> outputHFile = open(outputHTmp)
> outputHContents = outputHFile.read()
> outputHFile.close()
> -os.unlink(outputHTmp)
>
> # Rewrite the generated header with #include guards.
> outputH = os.path.join(outputDir, inputRoot + '.h')
>
Thanks. I've confirmed the problem, and that this fixes it.
I added it into version 2 of our patch.
ĸen
--
Juliet's version of cleanliness was next to godliness, which was to
say it was erratic, past all understanding and was seldom seen.
-- Unseen Academicals
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
