On Fri, 30 Oct 2020 18:15:49 -0500 Ken Moffat via blfs-dev wrote:
> I see we've already had one set of fixes for changes in icu68, I
> hope it is not going to trash a lot of things.
>
> I've been building libxml2 --with-icu for some time, that breaks:
>
> /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
> -I./include -I./include -pedantic -Wall -Wextra -Wshadow -Wpointer-arith
> -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes
> -Wmissing-prototypes -Wnested-externs -Winline -Wredundant-decls
> -Wno-long-long -Wno-format-extra-args -D_REENTRANT -O3 -march=native
> -fstack-clash-protection -D_FORTIFY_SOURCE=2 -fstack-protector-strong -MT
> encoding.lo -MD -MP -MF .deps/encoding.Tpo -c -o encoding.lo encoding.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./include -pedantic
> -Wall -Wextra -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings
> -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
> -Winline -Wredundant-decls -Wno-long-long -Wno-format-extra-args -D_REENTRANT
> -O3 -march=native -fstack-clash-protection -D_FORTIFY_SOURCE=2
> -fstack-protector-strong -MT encoding.lo -MD -MP -MF .deps/encoding.Tpo -c
> encoding.c -fPIC -DPIC -o .libs/encoding.o
> encoding.c: In function 'xmlEncOutputChunk':
> encoding.c:1961:31: error: 'TRUE' undeclared (first use in this function)
> 1961 | TRUE);
> | ^~~~
> encoding.c:1961:31: note: each undeclared identifier is reported only once
> for each function it appears in
> make[2]: *** [Makefile:1287: encoding.lo] Error 1
>
> This comes from encoding.c
>
> #ifdef LIBXML_ICU_ENABLED
> else if (handler->uconv_out != NULL) {
> ret = xmlUconvWrapper(handler->uconv_out, 0, out, outlen, in, inlen,
> TRUE);
> }
> #endif /* LIBXML_ICU_ENABLED */
>
> For the moment I can't see anything online (it looks like we are on
> the bleeding edge using icu68) so I'll just work around it by
> omitting --with-icu for the moment so I can get on with looking at
> the consequences of python2 using altinstall (more on that when I've
> got more things built).
>
> ĸen
> --
> The people next door oppress me all night long. I tell them: I work
> all day, a man's got to have some time to learn to play the tuba.
> That's oppression, that is. [ Guards! Guards! ]
> --
> http://lists.linuxfromscratch.org/listinfo/blfs-dev
> FAQ: http://www.linuxfromscratch.org/blfs/faq.html
> Unsubscribe: See the above information page
The fix is simple: replace TRUE by true and FALSE by false wherever it is
needed.
The requirement is pervasive. I have 3 packages that needed changes. The
qtwebengine touches a lot of files.
The one I had to give up on is libreoffice because there were changes needed in
the external tarballs.
I went with --without-system-icu for that and expect it to be needed for a long
time until everyone catches up.
I really wish upstreams would consider the amount of work they cause for
everyone.
There is one in particular that has made numerous incremental API changes and
does not seem to understand the reason why an soname needs to be bumped.
I can provide the patch files on request, but be warned they aren't done in a
way that preserves building with older versions of ICU.
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
