On Mon, 2021-03-08 at 19:49 +0800, Kevin Buckley via blfs-dev wrote: > 1) > > x7fonts.xml has an > > as_root rm -rf $packagedir > > in the loop over packages, although x7apps doesn't have the as_root, > and nor does x7libs.
Not sure in this case, but being root for removing a build tree may occasionally be necessary because "as_root make install" may create files owned by root in the directory. In this case, as_root was added at revision 12833 (2014-03-07) with the log "Tweak font installation script". So it seems to have been done on purpose. Note that at the time, there were many more fonts installed, so the need for "as_root" may have disappeared when removing the extra fonts (some of which are now in the "Xorg Legacy" page, which does not have "as_root" for removing the build tree). > > > 2) > > Installation of intel-vaapi-driver > > appears to unpack the intel-vaapi-driver sources into the libva > directory. > > Does it need to be installed from within the libva source directory? > > I'd have thought one would have cd-d back up out of the libva dir? Well, I'm responsible for this... It does not hurt, and it allows to have only one directory to remove instead of two after building... It's this way for all the pages with two packages on them (see sassc for example)(I hate those pages, they just show our laziness). > > > 3) > > I also noted that many of the X Window System package instructions > (although I think it's a BLFS wide thing) follow this form : > > Installation of package > > Install <application>package</application> by running the following > commands: > > ./configure $XORG_CONFIG && > make > > This package does not come with a test suite. > > Now, as the root user: > > make install > > > I'd like to suggest that the "Install" sentence there should be > replaced by > > "Build <application>package</application> by running ..." > > as that's what the combined configure+make commands actually do > and that the "Now, as the root user:" becomes > > "As the root user, install the package as follows:" > > as that is what the commands to be done as the root user do. Well, I'm not a native English speaker, so I might be wrong, but I understand the first sentence is for all what follows, including the "Now, as the root user" part. > > > If truth be told, I'd rather see the "Patch; Configure; Make; Make > Install" > stages in separate boxes but think that's a bit too much of an ask? Well, that's a design decision made long ago (and before I started contributing). Changing it means changing ~800 pages of the book. That could be automated with a carefully crafted XSL stylesheet, but verification would be tedious. Pierre -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
