On Thu, 26 Apr 2012 15:50:51 +0100
Bruce Dubbs <[email protected]> wrote:

> Andrew Benton wrote:
> > +       case KDSKBLED:
> > +               if (!perm)
> > +                       return -EPERM;
> > +               if (arg & ~0x77)
> > +                       return -EINVAL;
> > +                spin_lock_irqsave(&kbd_event_lock, flags);
> > +               kbd->ledflagstate = (arg & 7);
> > +               kbd->default_ledflagstate = ((arg >> 4) & 7);
> > +               set_leds();
> > +                spin_unlock_irqrestore(&kbd_event_lock, flags);
> > +               break;       // <<<<<  change to return 0;

> It looks like an error in the code.  The only case that doesn't return is
> KDSKBLED.  The break then goes to return -ENOIOCTLCMD which doesn't seem 
> right.
> Try changing the break to return 0;

Thanks, I changed it to return 0; but sadly the kernel will not compile:

  LD      vmlinux.o
  MODPOST vmlinux.o
  GEN     .version
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `do_compute_shiftstate':
keyboard.c:(.text+0x5fe03): undefined reference to `key_maps'
drivers/built-in.o: In function `k_slock':
keyboard.c:(.text+0x6043c): undefined reference to `key_maps'
drivers/built-in.o: In function `handle_diacr':
keyboard.c:(.text+0x6048a): undefined reference to `accent_table_size'
keyboard.c:(.text+0x60493): undefined reference to `accent_table'
keyboard.c:(.text+0x604bc): undefined reference to `accent_table'
drivers/built-in.o: In function `kbd_event':
keyboard.c:(.text+0x60785): undefined reference to `key_maps'
keyboard.c:(.text+0x60a2e): undefined reference to `key_maps'
drivers/built-in.o: In function `k_fn.part.9':
keyboard.c:(.text+0x60ce8): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x6187c): undefined reference to `accent_table_size'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x61891): undefined reference to `accent_table'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x618a0): undefined reference to `accent_table'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x619a7): undefined reference to `accent_table'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x619bf): undefined reference to `accent_table_size'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x61a5a): undefined reference to `accent_table_size'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x61a61): undefined reference to `accent_table'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x61a75): undefined reference to `accent_table'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x61afc): undefined reference to `accent_table_size'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x61b09): undefined reference to `accent_table'
drivers/built-in.o: In function `vt_do_diacrit':
(.text+0x61b81): undefined reference to `accent_table_size'
drivers/built-in.o: In function `vt_do_kdsk_ioctl':
(.text+0x6207d): undefined reference to `key_maps'
drivers/built-in.o: In function `vt_do_kdsk_ioctl':
(.text+0x62125): undefined reference to `key_maps'
drivers/built-in.o: In function `vt_do_kdsk_ioctl':
(.text+0x621c0): undefined reference to `key_maps'
drivers/built-in.o: In function `vt_do_kdsk_ioctl':
(.text+0x621cf): undefined reference to `key_maps'
drivers/built-in.o: In function `vt_do_kdsk_ioctl':
(.text+0x62242): undefined reference to `keymap_count'
drivers/built-in.o: In function `vt_do_kdsk_ioctl':
(.text+0x62250): undefined reference to `key_maps'
drivers/built-in.o: In function `vt_do_kdsk_ioctl':
(.text+0x62276): undefined reference to `keymap_count'
drivers/built-in.o: In function `vt_do_kdsk_ioctl':
(.text+0x622b4): undefined reference to `keymap_count'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x623c0): undefined reference to `funcbufleft'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x623cc): undefined reference to `funcbufsize'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x623d9): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x623eb): undefined reference to `funcbufptr'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x6241e): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x6248a): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x62491): undefined reference to `funcbufleft'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x624b4): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x625b5): undefined reference to `funcbufptr'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x625cc): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x625df): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x625fc): undefined reference to `func_buf'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x62617): undefined reference to `funcbufptr'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x62620): undefined reference to `funcbufleft'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x62626): undefined reference to `funcbufsize'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x6262d): undefined reference to `funcbufsize'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x62633): undefined reference to `funcbufleft'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x62640): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x62663): undefined reference to `funcbufptr'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x626c7): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x626d7): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x626f9): undefined reference to `funcbufptr'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x6271e): undefined reference to `funcbufptr'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x6273f): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x62755): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x6276d): undefined reference to `func_table'
drivers/built-in.o: In function `vt_do_kdgkb_ioctl':
(.text+0x6277f): undefined reference to `func_table'
make: *** [.tmp_vmlinux1] Error 1

Andy
-- 
http://linuxfromscratch.org/mailman/listinfo/blfs-support
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to