On Wed, Oct 05, 2016 at 09:50:30PM +0100, akhiezer wrote: > > From: "Cliff McDiarmid" <[email protected]> > > Date: Wed, 5 Oct 2016 20:35:36 +0200 > > Subject: [blfs-support] Solid failure in Frameworks-5.25.0 > > > > Hi > > > > Does anyone know what's causing this when building Solid as part of > > Frameworks? Or has anyone seen this before? > > > > > > [ 40%] Building C object > > src/solid/CMakeFiles/KF5Solid_static.dir/predicate_lexer.c.o > > /mnt/home/cliffys/frameworks-5.26.0/solid-5.25.0/build/src/solid/predicate_lexer.c: > > In function âSolidensure_buffer_stackâ: > > /mnt/home/cliffys/frameworks-5.26.0/solid-5.25.0/build/src/solid/predicate_lexer.c:1587:21: > > error: C++ style comments are not allowed in ISO C90 > > num_to_alloc = 1; // After all that talk, this was set to 1 anyways... > > ^ > > Dealing with the info 'in isolation' - haven't gone back and looked at book > pages: > > either: > ==== > * change that line, in: > > /mnt/home/cliffys/frameworks-5.26.0/solid-5.25.0/build/src/solid/predicate_lexer.c > > , to: > num_to_alloc = 1; /* After all that talk, this was set to 1 anyways... > */ > But you might hit similar issue in other files: so ref following option, > below. > > * or: > tell the compiler to use an appropriate C version later than 'ISO C90'; or > at least to be relaxed about such '// ...' comment styles. > ==== >
Yes, it seems strange that it is setting things up as if for an old compiler. On 7.10 in solid-5.25.0 mine reported -- The C compiler identification is GNU 6.2.0 -- The CXX compiler identification is GNU 6.2.0 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done In 7.9-rc1 I had similar output with 5.18, except the compiler was 5.3.0. I can't go back and compare that source to 5.25.0 because http://download.kde.org/stable/frameworks/ has nothing before 5.20, but I will be very surprised if '//' comments are a recent addition. So, which compiler are you using, and what does cmake think it is when trying to build solid ? Or did you accidentally use some CFLAGS or CXXFLAGS to force the version ? ĸen -- `I shall take my mountains', said Lu-Tze. `The climate will be good for them.' -- Small Gods -- http://lists.linuxfromscratch.org/listinfo/blfs-support FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
